This one time, at band camp, Arnaud Fontaine said: > Hello, > > Attached is the diff for my webcalendar 1.0.2-2.1 NMU. Thanks to Julien > Danjou, Raphaël Hertzog and Gustavo Franco for their help.
This looks wrong in several ways. Please hold off the NMU just a little longer. > diff -urN webcalendar-1.0.2.old/debian/changelog > webcalendar-1.0.2/debian/changelog > --- webcalendar-1.0.2.old/debian/changelog 2006-04-20 17:34:12.000000000 > +0200 > +++ webcalendar-1.0.2/debian/changelog 2006-04-20 22:08:45.000000000 > +0200 > @@ -1,3 +1,13 @@ > +webcalendar (1.0.2-2.1) unstable; urgency=low > + > + * Non-maintainer upload. > + * Fix debian/webcalendar.postinst and debian/webcalendar.config. > + Rename settings.conf to settings.php. Remove useless > + debian/tools. Closes: #360690. The main problem was lost +x perms, most likely due to patch, and me not noticing that the x bit was lost before upload. I don't know that wholesale reversion of packaging decisions is a good thing to do in an NMU. > diff -urN webcalendar-1.0.2.old/debian/patches/00list > webcalendar-1.0.2/debian/patches/00list > --- webcalendar-1.0.2.old/debian/patches/00list 2006-04-20 > 17:34:12.000000000 +0200 > +++ webcalendar-1.0.2/debian/patches/00list 2006-04-20 22:01:53.000000000 > +0200 > @@ -1 +1,2 @@ > 01_config_patch > +01_pgsql_patch This one strikes me as odd - why patch so many files, when you could just feed it the right thing in the first place? In short, I see that this NMU appears to introduce several rather major changes that address problems in the bug report in a rather strange way. Please don't upload yet. I understand the maintainer (and I, as his sponsor) have been remiss in not addressing this RC bug. Thanks, -- ----------------------------------------------------------------- | ,''`. Stephen Gran | | : :' : [EMAIL PROTECTED] | | `. `' Debian user, admin, and developer | | `- http://www.debian.org | -----------------------------------------------------------------
signature.asc
Description: Digital signature
