Control: tags -1 + moreinfo On 2021-03-22 11:07:24, Taowa wrote: > Package: release.debian.org > Severity: normal > User: release.debian....@packages.debian.org > Usertags: unblock > X-Debbugs-Cc: ni...@debian.org > > Please unblock package yubikey-manager > > [ Reason ] > -3 fixes an RC bug #984480 by ensuring that the symlink for the > python3-yubikey-manager package is properly generated. > > There is also a change in the build process that replaces linking a file > with a patch. This change was made because this link at clean-time led > to unrepresentable changes to the source. > > [ Impact ] > yubikey-manager and yubioath-desktop will be autoremoved should this not > be unblocked. > > [ Tests ] > I manually tested whether the change fixed the symlink in question by > upgrading from the version in stable to -3. > > I also manually tested whether the change to the build process had any > effects. It did not seem to. > > [ Risks ] > I do not believe this change poses any substantial risks. > > [ Checklist ] > [x] all changes are documented in the d/changelog > [x] I reviewed all changes and I approve them > [x] attach debdiff against the package in testing > > [ Other info ] > Thanks! > > unblock yubikey-manager/4.0.0~a1-3
> diff -Nru yubikey-manager-4.0.0~a1/debian/changelog > yubikey-manager-4.0.0~a1/debian/changelog > --- yubikey-manager-4.0.0~a1/debian/changelog 2021-02-11 06:33:27.000000000 > -0500 > +++ yubikey-manager-4.0.0~a1/debian/changelog 2021-03-20 14:51:24.000000000 > -0400 > @@ -1,3 +1,12 @@ > +yubikey-manager (4.0.0~a1-3) unstable; urgency=medium > + > + * Update maintscript to symlink doc directories for > + python3-yubikey-manager and yubikey-manager. > + Closes: #984480 > + * Add myself as an uploader. > + > + -- Taowa <ta...@debian.org> Sat, 20 Mar 2021 14:30:00 -0500 > + > yubikey-manager (4.0.0~a1-2) unstable; urgency=medium > > * Cherry-pick upstream fix for OATH on Yubikey NEO > diff -Nru yubikey-manager-4.0.0~a1/debian/control > yubikey-manager-4.0.0~a1/debian/control > --- yubikey-manager-4.0.0~a1/debian/control 2021-02-11 06:33:27.000000000 > -0500 > +++ yubikey-manager-4.0.0~a1/debian/control 2021-03-20 14:51:09.000000000 > -0400 > @@ -1,7 +1,8 @@ > Source: yubikey-manager > Maintainer: Debian Authentication Maintainers > <pkg-auth-maintain...@lists.alioth.debian.org> > Uploaders: Afif Elghraoui <a...@debian.org>, > - nicoo <ni...@debian.org> > + nicoo <ni...@debian.org>, > + Taowa <ta...@debian.org> > Section: utils > Priority: optional > Rules-Requires-Root: no > diff -Nru yubikey-manager-4.0.0~a1/debian/patches/0003-create-setup-py.patch > yubikey-manager-4.0.0~a1/debian/patches/0003-create-setup-py.patch > --- yubikey-manager-4.0.0~a1/debian/patches/0003-create-setup-py.patch > 1969-12-31 19:00:00.000000000 -0500 > +++ yubikey-manager-4.0.0~a1/debian/patches/0003-create-setup-py.patch > 2021-03-20 14:35:37.000000000 -0400 > @@ -0,0 +1,45 @@ > +Description: add a setup.py > +Author: Taowa <ta...@debian.org> > +Origin: Created from the setup.py manually edited by nicoo <ni...@debian.org> > +Forwarded: not-needed > +Last-Update: 2021-03-20 > +--- > +This patch header follows DEP-3: http://dep.debian.net/deps/dep3/ > +Index: yubikey-manager/setup.py > +=================================================================== > +--- /dev/null 1970-01-01 00:00:00.000000000 +0000 > ++++ yubikey-manager/setup.py 2021-03-20 11:28:00.212298932 -0400 > +@@ -0,0 +1,33 @@ > ++ > ++# -*- coding: utf-8 -*- > ++ > ++# DO NOT EDIT THIS FILE! > ++# This file has been autogenerated by dephell <3 > ++# https://github.com/dephell/dephell > ++ > ++try: > ++ from setuptools import setup > ++except ImportError: > ++ from distutils.core import setup > ++ > ++readme = '' > ++ > ++setup( > ++ long_description=readme, > ++ name='yubikey-manager', > ++ version='4.0.0a1', > ++ description='Tool for managing your YubiKey configuration.', > ++ python_requires='==3.*,>=3.6.0', > ++ project_urls={"homepage": "https://github.com/Yubico/yubikey-manager";, > "repository": "https://github.com/Yubico/yubikey-manager"}, > ++ author='Dain Nilsson', > ++ author_email='d...@yubico.com', > ++ license='BSD', > ++ keywords='yubikey yubiotp piv fido', > ++ classifiers=['Development Status :: 5 - Production/Stable', 'Intended > Audience :: End Users/Desktop', 'Topic :: Security :: Cryptography', 'Topic > :: Utilities'], > ++ entry_points={"console_scripts": ["ykman = ykman.cli.__main__:main"]}, > ++ packages=['ykman', 'ykman.cli', 'ykman.hid', 'ykman.pcsc', > 'ykman.scancodes', 'yubikit', 'yubikit.core'], > ++ package_dir={"": "."}, > ++ package_data={"ykman": [".mypy_cache/*.TAG", ".mypy_cache/3.9/*.json", > ".mypy_cache/3.9/_typeshed/*.json", ".mypy_cache/3.9/collections/*.json", > ".mypy_cache/3.9/cryptography/*.json", > ".mypy_cache/3.9/cryptography/hazmat/*.json", > ".mypy_cache/3.9/cryptography/hazmat/backends/*.json", > ".mypy_cache/3.9/cryptography/hazmat/primitives/*.json", > ".mypy_cache/3.9/cryptography/hazmat/primitives/asymmetric/*.json", > ".mypy_cache/3.9/cryptography/hazmat/primitives/ciphers/*.json", > ".mypy_cache/3.9/cryptography/hazmat/primitives/serialization/*.json", > ".mypy_cache/3.9/cryptography/x509/*.json", ".mypy_cache/3.9/email/*.json", > ".mypy_cache/3.9/email/mime/*.json", ".mypy_cache/3.9/html/*.json", > ".mypy_cache/3.9/http/*.json", ".mypy_cache/3.9/importlib/*.json", > ".mypy_cache/3.9/logging/*.json", ".mypy_cache/3.9/os/*.json", > ".mypy_cache/3.9/six/*.json", ".mypy_cache/3.9/six/moves/*.json", > ".mypy_cache/3.9/six/moves/urllib/*.json", ".mypy_cache/3.9/tkinter/*.json", > ".mypy_cache/3.9/unittest/*.json", ".mypy_cache/3.9/urllib/*.json", > ".mypy_cache/3.9/ykman/*.json", ".mypy_cache/3.9/ykman/scancodes/*.json"]}, Thankfully the package does not install the .mypy_cache, but listing all the caches in package_data seems odd. > ++ install_requires=['click==7.*,>=7.0.0', 'cryptography>=3.0.0,<<4', > 'dataclasses==0.*,>=0.8.0; python_version < "3.7"', 'fido2<1.0,>=0.9', > 'pyopenssl==17.*,>=0.15.1,>=17.0.0', 'pyscard==2.*,>=2.0.0', 'pywin32>=223; > sys_platform == "win32"'], Note that python3-cryptography and python3-fido2 in stable do not satisfy these version requirements. I would expect that the version requirements would be reflected in Depends. Also listing both >= 0.15.1 and >= 17.0.0 for pyopenssl is redundant. > ++) > ++ > diff -Nru yubikey-manager-4.0.0~a1/debian/patches/series > yubikey-manager-4.0.0~a1/debian/patches/series > --- yubikey-manager-4.0.0~a1/debian/patches/series 2021-02-11 > 06:33:27.000000000 -0500 > +++ yubikey-manager-4.0.0~a1/debian/patches/series 2021-03-20 > 11:34:26.000000000 -0400 > @@ -1,2 +1,3 @@ > 0001-Fix-upstream-changelog.patch > 0002-Fix-OATH-truncate-for-NEO.patch > +0003-create-setup-py.patch > diff -Nru yubikey-manager-4.0.0~a1/debian/python3-ykman.maintscript > yubikey-manager-4.0.0~a1/debian/python3-ykman.maintscript > --- yubikey-manager-4.0.0~a1/debian/python3-ykman.maintscript 2021-02-11 > 06:33:27.000000000 -0500 > +++ yubikey-manager-4.0.0~a1/debian/python3-ykman.maintscript 1969-12-31 > 19:00:00.000000000 -0500 > @@ -1,3 +0,0 @@ > -# Handle dir-to-symlink migration for package docs > -dir_to_symlink /usr/share/doc/python3-yubikey-manager > /usr/share/doc/python3-ykman 3.1.1-1 python3-yubikey-manager > -dir_to_symlink /usr/share/doc/yubikey-manager > /usr/share/doc/python3-ykman 3.1.1-1 yubikey-manager > diff -Nru yubikey-manager-4.0.0~a1/debian/python3-yubikey-manager.maintscript > yubikey-manager-4.0.0~a1/debian/python3-yubikey-manager.maintscript > --- yubikey-manager-4.0.0~a1/debian/python3-yubikey-manager.maintscript > 1969-12-31 19:00:00.000000000 -0500 > +++ yubikey-manager-4.0.0~a1/debian/python3-yubikey-manager.maintscript > 2021-03-20 14:26:47.000000000 -0400 > @@ -0,0 +1,2 @@ > +# Handle dir-to-symlink migration for package docs > +dir_to_symlink /usr/share/doc/python3-yubikey-manager > /usr/share/doc/python3-ykman 4.0.0~ python3-yubikey-manager > diff -Nru yubikey-manager-4.0.0~a1/debian/rules > yubikey-manager-4.0.0~a1/debian/rules > --- yubikey-manager-4.0.0~a1/debian/rules 2021-02-11 06:33:27.000000000 > -0500 > +++ yubikey-manager-4.0.0~a1/debian/rules 2021-03-20 14:32:02.000000000 > -0400 > @@ -5,9 +5,6 @@ > %: > dh $@ --with python3 --buildsystem=pybuild > > -override_dh_auto_clean: > - ln -s debian/setup.py > - > # Disable tests, as some of the test dependencies have yet to be packaged > override_dh_auto_test: > : > diff -Nru yubikey-manager-4.0.0~a1/debian/source/lintian-overrides > yubikey-manager-4.0.0~a1/debian/source/lintian-overrides > --- yubikey-manager-4.0.0~a1/debian/source/lintian-overrides 1969-12-31 > 19:00:00.000000000 -0500 > +++ yubikey-manager-4.0.0~a1/debian/source/lintian-overrides 2021-03-20 > 11:55:48.000000000 -0400 > @@ -0,0 +1,2 @@ > +# Override missing upstream signature as the alpha build does not have one. > +orig-tarball-missing-upstream-signature This change is not documented and also not really necessary. Cheers > diff -Nru yubikey-manager-4.0.0~a1/debian/yubikey-manager.maintscript > yubikey-manager-4.0.0~a1/debian/yubikey-manager.maintscript > --- yubikey-manager-4.0.0~a1/debian/yubikey-manager.maintscript > 1969-12-31 19:00:00.000000000 -0500 > +++ yubikey-manager-4.0.0~a1/debian/yubikey-manager.maintscript > 2021-03-20 14:26:37.000000000 -0400 > @@ -0,0 +1,2 @@ > +# Handle dir-to-symlink migration for package docs > +dir_to_symlink /usr/share/doc/yubikey-manager > /usr/share/doc/python3-ykman 4.0.0~ yubikey-manager -- Sebastian Ramacher
