Package: dvdbackuo Version: 0.1.1-4 Severity: minor In dvdbackup.c, there is (several times) the following line:
if (mkdir(targetname, S_IRUSR | S_IWUSR | S_IXUSR) != 0) {
The result is that the directories are created with paranoid permissions.
Unlike mail or password-holding files, a DVD backup has no reason to be
specifically private. Therefore, the standard umask mechanism should apply:
all files should be created 666 (or 777 if they are executable) and all
directories 777, with the umask bits automatically turned off.
So I suggest to fix this line like this:
if (mkdir(targetname, 0777) != 0) {
The following line (repeated several times too) should also be fixed:
-if ((streamout = open(targetname, O_WRONLY | O_CREAT, 0644)) == -1) {
+if ((streamout = open(targetname, O_WRONLY | O_CREAT, 0666)) == -1) {
Regards,
--
Nicolas George
signature.asc
Description: Digital signature
