Hi Marc, > Is it ok for you if I close this bug?
Sure. > > Most likely unrelated, but one thing I did notice when checking the > > code is that sudo_mkdir_parents might UB if path is an empty string, > > since it first does "char *slash = path; strchr (slash + 1, '/');". > > > > Now I don't know if it's actually possible that it's called with an > > empty string, so it might not be an actual bug, but since I see it's > > coded very defensively overall, an empty string check here might not > > hurt. > > Would it be ok for you to file an issue in upstream's bugzilla? Or would > it be more comforable for you if I took this issue upstream? It is > generally more useful when the bug reporter has a direct communications > link to upstream in such cases. I'd prefer if you do it. I don't really have anything more to say about it, nor any kind of test case. (As I said, it may not even be a bug, just a matter of defensive programming.) Greetings, Frank
