Package: src:vinagre Severity: grave Version: 3.22.0-8
For a while now, vinagre when running against FreeRDP >= 2.0.0 has been broken in Debian. When launching an RDP session, the user sees a GTK window with a black rectangle in the middle.
A fix proposed by FreeRDP upstream is https://gitlab.gnome.org/GNOME/vinagre/-/commit/404a56a11469ef24a1df632847465030d81db091.patch See: https://gitlab.gnome.org/GNOME/vinagre/-/merge_requests/12However, the vinagre version in Debian will not be fixed after the referenced patch (an adapted version of it for vinagre 3.22.0) has been applied (I just tested that).
Let me know, if I can give any more input on this. I saw from other open bugs that vinagre upstream is scarcely maintained. Does it make sense to ship vinagre in Debian 11? If yes, let me know how I can help fixing this issue.
Greets, Mike -- DAS-NETZWERKTEAM c\o Technik- und Ökologiezentrum Eckernförde Mike Gabriel, Marienthaler Str. 17, 24340 Eckernförde mobile: +49 (1520) 1976 148 landline: +49 (4351) 850 8940 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de
>From 404a56a11469ef24a1df632847465030d81db091 Mon Sep 17 00:00:00 2001 From: Ondrej Holy <oh...@redhat.com> Date: Fri, 15 May 2020 15:43:37 +0200 Subject: [PATCH] plugins/rdp: Fix hangs with recent FreeRDP versions Connection to all my testing servers fails with "SERVER BUG: The support for this feature was not announced! Use /relax-order-checks to ignore" currently. This happens always with current FreeRDP versions after https://github.com/FreeRDP/FreeRDP/pull/4926 has been merged. This can be fixed by the usage of /relax-order-checks option, however, this option should be used only if necessary needed and it should not be needed in most of the cases. This currenlty happens always as it interfere with our custom OrderSupports settings. Let's use the default OrderSupports settings to fix this issue, which is possible thanks to https://github.com/FreeRDP/FreeRDP/pull/5057. See: https://gitlab.gnome.org/GNOME/gtk-frdp/-/issues/27 --- configure.ac | 2 +- plugins/rdp/vinagre-rdp-tab.c | 27 --------------------------- 2 files changed, 1 insertion(+), 28 deletions(-) --- a/configure.ac +++ b/configure.ac @@ -58,7 +58,7 @@ AM_CONDITIONAL([VINAGRE_ENABLE_SSH], [test "x$have_ssh" = "xyes"]) # Whether to enable support for RDP. -RDP_DEPS="freerdp2 x11" +RDP_DEPS="freerdp2 >= 2.0.0 x11" AC_ARG_ENABLE([rdp], [AS_HELP_STRING([--disable-rdp], [Disable Remote Desktop Protocol (RDP) support])]) --- a/plugins/rdp/vinagre-rdp-tab.c +++ b/plugins/rdp/vinagre-rdp-tab.c @@ -522,9 +522,9 @@ static BOOL frdp_pre_connect (freerdp *instance) { +#if HAVE_FREERDP_1_1 rdpSettings *settings = instance->settings; -#if HAVE_FREERDP_1_1 settings->OrderSupport[NEG_DSTBLT_INDEX] = TRUE; settings->OrderSupport[NEG_PATBLT_INDEX] = TRUE; settings->OrderSupport[NEG_SCRBLT_INDEX] = TRUE; @@ -549,31 +549,6 @@ settings->OrderSupport[NEG_POLYGON_CB_INDEX] = FALSE; settings->OrderSupport[NEG_ELLIPSE_SC_INDEX] = FALSE; settings->OrderSupport[NEG_ELLIPSE_CB_INDEX] = FALSE; -#else - settings->order_support[NEG_DSTBLT_INDEX] = true; - settings->order_support[NEG_PATBLT_INDEX] = true; - settings->order_support[NEG_SCRBLT_INDEX] = true; - settings->order_support[NEG_OPAQUE_RECT_INDEX] = true; - settings->order_support[NEG_DRAWNINEGRID_INDEX] = false; - settings->order_support[NEG_MULTIDSTBLT_INDEX] = false; - settings->order_support[NEG_MULTIPATBLT_INDEX] = false; - settings->order_support[NEG_MULTISCRBLT_INDEX] = false; - settings->order_support[NEG_MULTIOPAQUERECT_INDEX] = true; - settings->order_support[NEG_MULTI_DRAWNINEGRID_INDEX] = false; - settings->order_support[NEG_LINETO_INDEX] = true; - settings->order_support[NEG_POLYLINE_INDEX] = true; - settings->order_support[NEG_MEMBLT_INDEX] = true; - settings->order_support[NEG_MEM3BLT_INDEX] = false; - settings->order_support[NEG_MEMBLT_V2_INDEX] = true; - settings->order_support[NEG_MEM3BLT_V2_INDEX] = false; - settings->order_support[NEG_SAVEBITMAP_INDEX] = false; - settings->order_support[NEG_GLYPH_INDEX_INDEX] = true; - settings->order_support[NEG_FAST_INDEX_INDEX] = true; - settings->order_support[NEG_FAST_GLYPH_INDEX] = false; - settings->order_support[NEG_POLYGON_SC_INDEX] = false; - settings->order_support[NEG_POLYGON_CB_INDEX] = false; - settings->order_support[NEG_ELLIPSE_SC_INDEX] = false; - settings->order_support[NEG_ELLIPSE_CB_INDEX] = false; #endif return TRUE;
pgpsbnc6UgEV3.pgp
Description: Digitale PGP-Signatur
