On Tue, 2021-02-23 at 00:22 +0800, Shengjing Zhu wrote: > On Mon, Feb 22, 2021 at 02:47:20PM +0000, Luca Boccassi wrote: > > Source: sdbus-cpp > > Version: 0.8.3-3 > > Tags: patch > > > > Dear Maintainer, > > > > Please find attached some patches to enable multiarch support and > > nodoc/nocheck build profiles (for easier > > crossbuild/bootstrap/backport). > > > > -- > > Kind regards, > > Luca Boccassi > > Subject: [PATCH 1/5] libsdbus-c++-dev: downgrade Depends on libsdbus-c++-bin > > to Suggests > > > > It is not actually necessary to use the library headers and link against > > the shared object, it's a useful development tool. A Suggests is enough > > and doesn't have side effects on Multiarch installations. > > --- > > Will apply after bullseye. Otherwise anbox will FTBFS.
This is required for multiarch though. An alternative could be to mark the dependency as :native and the bin package as "Multi-Arch: allowed". Then it should be satisfiable from another architecture (eg: libsdbuscpp-dev:i386 can be installed with libsdbuscpp-bin:amd64). > > Subject: [PATCH 2/5] Enable Multiarch support > > Applied > > > From 14bff4c1d7c4c1af021d189ff4df378e41d50141 Mon Sep 17 00:00:00 2001 > > From: Luca Boccassi <luca.bocca...@microsoft.com> > > Date: Mon, 22 Feb 2021 13:43:34 +0000 > > Subject: [PATCH 3/5] Add support for nocheck build option/profile > > > > Applied without checking DEB_BUILD_PROFILES. > The spec says: > > Builds that set this profile must also add nocheck to DEB_BUILD_OPTIONS > > So the DEB_BUILD_OPTIONS is always available. With DEB_BUILD_OPTIONS and > debhelper-compat 13, there's no need to check nocheck in dh_auto_test. > > > Subject: [PATCH 4/5] Mark d/rules as executable > > > > Applied. > > > Subject: [PATCH 5/5] Add support for nodoc build option/profile > > > > Applied without check nodoc in d/rules. As building doc is already in > -indep target. And the -doc is the only arch all package. That adds an additional requirement though - doing a binary build together with the nodoc profile. Also, the binary build will fail without passing -DBUILD_DOC=OFF to the binary configure, since it's default-enabled and will fail when looking for the doxygen binary. -- Kind regards, Luca Boccassi
signature.asc
Description: This is a digitally signed message part
