On Thu, Feb 04, 2021 at 09:10:40AM -0300, Antonio Terceiro wrote: > On Thu, Feb 04, 2021 at 08:30:58AM +0100, Marc Haber wrote: > > On Wed, Feb 03, 2021 at 12:27:52PM -0600, Corey Minyard wrote: > > > On Wed, Feb 03, 2021 at 10:40:46AM -0300, Antonio Terceiro wrote: > > > > Package: ser2net > > > > Version: 4.3.2-2 > > > > Severity: important > > > > > > > > Hi, > > > > > > > > Thanks for maintaining ser2net. > > > > > > > > When upgrading from 3.5 to 4.3.2, it now uses /etc/ser2net.yaml instead > > > > of the previously used /etc/ser2net.conf. This breaks any local > > > > configuration on upgrade. I don't expect my existing configuration to be > > > > automatically migrated over to the new format, but I would expect at > > > > least an entry in NEWS.Debian alerting me of that fact. > > > > > > Well, it's supposed to be backwards compatible. But I was able to > > > reproduce (I think, you didn't say what went wrong, which is always good > > > information). > > > > I think Antonio was rightfully complaining about the unannounced change > > from the old config format to the new YAML format. I forgot to write a > > NEWS file that is displayed on package update. > > > > In Debian, there is a general expectation tha packages contain to > > function during an update. I was too lazy to write a converter from the > > old format to the new format. The least I could have done was writing a > > NEWS file. I had that on my mind and thought I did, but I didn't. This > > will be fixed in the next upload. > > Beyond adding an NEWS entry, another easy thing you could do is > replacing the current command in ExecStart= by a wrapper script that > uses ser2net.conf if it exists (while printing a big fat warning), and > ser2net.yaml otherwise.
This is how ser2net currently works. It will load ser2net.yaml if it exists. If it does not, it will load ser2net.conf. It doesn't print a big fat warning, though. I can add that. Writing a converter wouldn't be too hard, I should have done that. There is some trickiness dealing with colons in device names, but I think that's the only hard thing. If you don't do this, I can do it.
