Hi Vasyl,
On Mon, Feb 01, 2021 at 02:02:28PM +0000, Vasyl Gello wrote:
> Hi Ian, Guido!
>
> > I'm going to reply to your next part in general terms. I hope Guido will
> > agree with me.
>
> Thanks for explanation! :) NMU looks not that scary thing for me!
> There is no need for NMU since Guido is here, but noted for the future.
>
> Guido, how is it best for you to review patches?
>
> * Attaching to bugs
> * Using Salsa cloned repo in my personal space
>
> As for breakage, the best solution I see here is to introduce new gbp.conf
> parameter
> like USCAN_SYMLINK={rename|symlink} plus check and warn the user if uscan's
> behavior
> is overridden by environment variable somewhere.
I think the best way is to figure out if we can't just drop the option
and have users configure it via `~/.devscripts.conf`. The reason i did
(unfortunately)
not act on it yet is that i didn't get around to test all the
possibilities like `--tarball-dir`, multiple tarballs, etc.
I went back in the git history the other day and didn't spot anything
obvious but didn't want to make the change close to Debian release
without thorough testing. So if you want to check that out, that'd be
great.
We have some network based tests see `GBP_NETWORK_TESTS` so if you want
to add some testing the different import cases with `--uscan` based
tests. We could cook up some watch files that pull in things from a
stable location.
Cheers,
-- Guido
>
> What do you think? If the approach is fine, let me craft a PR!
> --
> Vasyl Gello
> ==================================================
> Certified SolidWorks Expert
>
> Mob.:+380 (98) 465 66 77
>
> E-Mail: vasek.ge...@gmail.com
>
> Skype: vasek.gello
> ==================================================
> 호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다
