Source: fvwm1
Version: 1.24r-57
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu hirsute ubuntu-patch

Hi,

fvwm1 has implicit function declaration/pointer conversion errors in its
build logs that are flagged by Debian's build log scanner as an error
because they can lead to issues on 64-bit architectures. [1]

They also cause the package to fail to upload to Ubuntu's archive
without a patch.

In Ubuntu, the attached patch was applied to achieve the following:

  * Include header files to fix FTBFS due to implicit pointer conversions.

Thanks for considering the patch.

Logan

[1] https://qa.debian.org/bls/packages/f/fvwm1.html
only in patch2:
unchanged:
--- fvwm1-1.24r.orig/modules/FvwmBacker/Mallocs.c
+++ fvwm1-1.24r/modules/FvwmBacker/Mallocs.c
@@ -18,6 +18,7 @@
  * own risk. Permission to use this program for any purpose is given,
  * as long as the copyright is kept intact. */
 
+#include "Mallocs.h"
 #include "../../configure.h"
 #include <stdio.h>
 #include <stdlib.h>
only in patch2:
unchanged:
--- fvwm1-1.24r.orig/modules/FvwmWinList/Mallocs.c
+++ fvwm1-1.24r/modules/FvwmWinList/Mallocs.c
@@ -18,6 +18,7 @@
  * own risk. Permission to use this program for any purpose is given,
  * as long as the copyright is kept intact. */
 
+#include "Mallocs.h"
 #include "../../configure.h"
 #include <stdio.h>
 #include <stdlib.h>

Reply via email to