Control: tag -1 + help newcomer

Hi,

sorry for the late reply.

Quoting Mathias Behrle (2020-12-18 16:39:44)
> I am running a builder for the Tryton packages that is configured to provide
> a changes as well as a source.changes file. The first used for the upload to
> the reprepro mirror, the latter used to upload to Debian.
> 
> The results of the last builder run caused mismatches of checksums when
> importing to reprepro. Indeed the control of the checksums prooved to be
> wrong. I suspect the following lines in the build logs to be the
> culprit:
> 
> """
> Signature with key 'mathi...@m9s.biz' requested:
>  signfile dsc 
> /home/mathiasb/bin/tryton/debian_builder/results/sid/tryton-server_5.0.30-1.dsc
>  mathi...@m9s.biz
> 
>  fixup_buildinfo 
> /home/mathiasb/bin/tryton/debian_builder/results/sid/tryton-server_5.0.30-1.dsc
>  
> /home/mathiasb/bin/tryton/debian_builder/results/sid/tryton-server_5.0.30-1_amd64.buildinfo
>  signfile buildinfo 
> /home/mathiasb/bin/tryton/debian_builder/results/sid/tryton-server_5.0.30-1_amd64.buildinfo
>  mathi...@m9s.biz
> 
>  fixup_changes dsc 
> /home/mathiasb/bin/tryton/debian_builder/results/sid/tryton-server_5.0.30-1.dsc
>  
> /home/mathiasb/bin/tryton/debian_builder/results/sid/tryton-server_5.0.30-1_amd64.changes
>  fixup_changes buildinfo 
> /home/mathiasb/bin/tryton/debian_builder/results/sid/tryton-server_5.0.30-1_amd64.buildinfo
>  
> /home/mathiasb/bin/tryton/debian_builder/results/sid/tryton-server_5.0.30-1_amd64.changes
>  signfile changes 
> /home/mathiasb/bin/tryton/debian_builder/results/sid/tryton-server_5.0.30-1_amd64.changes
>  mathi...@m9s.biz
> 
> Successfully signed dsc, buildinfo, changes files
> 
> ---> from here comes the problematic part from --source-only-changes
> 
>  unsignfile 
> /home/mathiasb/bin/tryton/debian_builder/results/sid/tryton-server_5.0.30-1_amd64.buildinfo
>  unsignfile 
> /home/mathiasb/bin/tryton/debian_builder/results/sid/tryton-server_5.0.30-1.dsc
>  signfile dsc 
> /home/mathiasb/bin/tryton/debian_builder/results/sid/tryton-server_5.0.30-1.dsc
>  mathi...@m9s.biz
> 
>  fixup_buildinfo 
> /home/mathiasb/bin/tryton/debian_builder/results/sid/tryton-server_5.0.30-1.dsc
>  
> /home/mathiasb/bin/tryton/debian_builder/results/sid/tryton-server_5.0.30-1_amd64.buildinfo
>  signfile buildinfo 
> /home/mathiasb/bin/tryton/debian_builder/results/sid/tryton-server_5.0.30-1_amd64.buildinfo
>  mathi...@m9s.biz
> 
>  fixup_changes dsc 
> /home/mathiasb/bin/tryton/debian_builder/results/sid/tryton-server_5.0.30-1.dsc
>  
> /home/mathiasb/bin/tryton/debian_builder/results/sid/tryton-server_5.0.30-1_source.changes
>  fixup_changes buildinfo 
> /home/mathiasb/bin/tryton/debian_builder/results/sid/tryton-server_5.0.30-1_amd64.buildinfo
>  
> /home/mathiasb/bin/tryton/debian_builder/results/sid/tryton-server_5.0.30-1_source.changes
>  signfile changes 
> /home/mathiasb/bin/tryton/debian_builder/results/sid/tryton-server_5.0.30-1_source.changes
>  mathi...@m9s.biz
> 
> Successfully signed dsc, buildinfo, changes files
> """
> 
> 
> Indeed running without --sourice-only-changes produced correct changes files.
> 
> The options used for the sbuild run are
> ['sbuild', '--quiet', '--chroot=sid-amd64-sbuild', 
> '--keyid=mathi...@m9s.biz', '--source', '--mailfrom="Debian Autobuilder 
> <sbu...@m9s.biz>"', '--mail-log-to=mathi...@m9s.biz', '--sbuild-mode=user', 
> '--no-apt-update', '--no-apt-upgrade', '--no-apt-distupgrade', 
> '--lintian-opts=-i -v -I -E --pedantic', '--bd-uninstallable-explainer=apt', 
> '--source-only-changes', 
> '/home/mathiasb/bin/tryton/debian_builder/build/tryton-server']
> 
> I am attaching for reference two changes files, one with
> --source-only-changes, one without.

I'm not surprised that this bug exists. The codepath you are using doesn't get
any testing. The official buildds are not using source-only-changes and those
who do, do not sign the build result with sbuild.

I'm tagging this with "help" and "newcomer". The fix is is likely to modify the
function close_build_log() in lib/Sbuild/Build.pm. There is a part that calls
debsign differently if SOURCE_ONLY_CHANGES is active and that part is probably
broken somehow. A merge request against https://salsa.debian.org/debian/sbuild
is greatly appreciated.

Since you are using sbuild in a buildd context I think you can work around this
bug for now by either manually signing or manually mangling your changes files?

Thanks!

cheers, josch

Attachment: signature.asc
Description: signature

Reply via email to