Hi,
upstream is preparing a new release and I am prepareing upload soon. Can
you please file an issue at https://github.com/cminyard/ser2net/issues
to speed things up?
Thanks!
Greetings
Marc
On Fri, Jan 22, 2021 at 03:04:28PM -0500, Dale Smith wrote:
> Package: ser2net
> Version: 3.5-2
> Severity: normal
>
> Dear Maintainer,
>
> * What led up to the situation?
>
> I wanted to place port specific info in my xterm title.
>
> * What exactly did you do (or not do) that was ineffective?
>
> Placing "\x1b" (ESC) in the banner along with "]0;" {text} "\a"
>
> * What was the outcome of this action?
>
> The "\x1b" is not read properly and sent as an ESC.
>
> * What outcome did you expect instead?
>
> An ESC char sent.
>
>
> The problem is in dataxfer.c. isdigit is being called istead of
> isxdigit. The fix is simple:
>
> diff --git a/dataxfer.c b/dataxfer.c
> index 5a7f91d..264828c 100644
> --- a/dataxfer.c
> +++ b/dataxfer.c
> @@ -1524,7 +1524,7 @@ process_str(port_info_t *port, net_info_t *netcon,
> op(data, val);
> return;
> }
> - if (!isdigit(*s))
> + if (!isxdigit(*s))
> continue;
> val = (val * 16) + from_hex_digit(*s);
> op(data, val);
>
>
>
>
>
>
>
> -- System Information:
> Debian Release: 10.7
> APT prefers stable-updates
> APT policy: (500, 'stable-updates'), (500, 'stable'), (500, 'oldstable')
> Architecture: amd64 (x86_64)
> Foreign Architectures: i386, armhf
>
> Kernel: Linux 4.19.0-13-amd64 (SMP w/4 CPU cores)
> Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
> LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/bash
> Init: systemd (via /run/systemd/system)
> LSM: AppArmor: enabled
>
> Versions of packages ser2net depends on:
> ii libc6 2.28-10
> ii libwrap0 7.6.q-28
> ii lsb-base 10.2019051400
>
> ser2net recommends no packages.
>
> Versions of packages ser2net suggests:
> ii telnet 0.17-41.2
>
> -- Configuration Files:
> /etc/ser2net.conf changed:
> BANNER:banner:\r\nser2net port \p device \d [\s] (Debian GNU/Linux)\r\n\r\n
> BANNER:title:\x1b]0;port \p device \d [\s] hex\a
> BANNER:nope:
> 3000:telnet:0:/dev/ttyACM0:115200 8DATABITS NONE 1STOPBIT title
> 3001:telnet:0:/dev/ttyACM1:115200 8DATABITS NONE 1STOPBIT title
> 3002:raw:0:/dev/ttyUSB0:115200 8DATABITS NONE 1STOPBIT title
> 3003:raw:0:/dev/ttyUSB1:115200 8DATABITS NONE 1STOPBIT title
>
>
> -- no debconf information
>
> -- debsums errors found:
> debsums: changed file /usr/sbin/ser2net (from ser2net package)
> diff --git a/dataxfer.c b/dataxfer.c
> index 5a7f91d..264828c 100644
> --- a/dataxfer.c
> +++ b/dataxfer.c
> @@ -1524,7 +1524,7 @@ process_str(port_info_t *port, net_info_t *netcon,
> op(data, val);
> return;
> }
> - if (!isdigit(*s))
> + if (!isxdigit(*s))
> continue;
> val = (val * 16) + from_hex_digit(*s);
> op(data, val);
--
-----------------------------------------------------------------------------
Marc Haber | "I don't trust Computers. They | Mailadresse im Header
Leimen, Germany | lose things." Winona Ryder | Fon: *49 6224 1600402
Nordisch by Nature | How to make an American Quilt | Fax: *49 6224 1600421
