On 2021-01-16, Nicolas Boulenguez wrote: > Source: u-boot > Followup-For: Bug #979296 > > Please only consider this version, rebased on 96b110eb. > 32296e74 is of little interest by itself, but documents 1f3d5824. > 6125bcad only applies on top, so I am submitting it here for now. > > Nothing seems unexpected in the output of the following commands (with > patches from bugs 979482 979660 980234 980235 980237 applied).
You've clearly put a lot of work into improving u-boot, so big thanks!
I suspect I will eventually apply the changes, but it is a bit
overwhelming for me to consider this late in the bullseye development
cycle...
On the other hand, it might be nice to get this in now, to avoid great
divergence between bullseye and bookworm, should we ever need to make
changes during the stable release cycle of bullseye...
I recognize it is a large change overall, but maybe there are a few more
incremental steps that could be split out into separate patches that
could make the progression easier to follow? Or maybe not; it is simply
a large change.
A few minor comments below.
> diff --git a/debian/control b/debian/control
> index 6f4cc17906..ff3e528e50 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -47,7 +47,9 @@ Description: A boot loader for embedded systems
> intended to be easy to port and to debug, and runs on many
> supported architectures, including PPC, ARM, MIPS, x86, m68k,
> NIOS, and Microblaze.
> - ${uboot:platforms}
> + .
> + Included platforms:
> + ${u-boot:platforms}
These changes are unrelated to restructuring the package. Please drop
them for now and/or submit separatelty. I've considered changes like
this in the past, though left them out... one reason is "u-boot"
contains no target platforms on armhf, for example, although at this
point it might be worth dropping the "u-boot" package on armhf.
> From: Nicolas Boulenguez <nico...@debian.org>
> Date: Thu, 14 Jan 2021 09:47:43 +0100
> Subject: [PATCH 4/4] Remove the pkg.u-boot.subarch.* profiles
>
> The new packaging is more flexible.
> ---
> debian/rules | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/debian/rules b/debian/rules
> index b207c032f1..3331ebffe5 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -37,14 +37,8 @@ notools := $(filter
> pkg.uboot.notools,$(DEB_BUILD_PROFILES))
>
> # Select the subarchs for DEB_HOST_ARCH
> all_subarchs := $(shell dh_listpackages --arch --no-package=u-boot-tools)
> -# DEB_BUILD_PROFILES=pkg.uboot.subarch.SUBARCH may
> -# limit builds to only certain subarchitectures
> -# e.g. pkg.uboot.subarch.rockchip will only build rockchip targets.
> -ifeq (,$(filter pkg.uboot.subarch.%,$(DEB_BUILD_PROFILES)))
> - built_subarchs := $(all_subarchs)
> -else
> - built_subarchs := $(patsubst pkg.uboot.subarch.%,u-boot-%,$(filter
> pkg.uboot.subarch.%,$(DEB_BUILD_PROFILES)))
> -endif
> +# This variable is intended for command line override:
> +built_subarchs := $(all_subarchs)
>
> %:
> # The -N options prevents a lots of warnings about obviously missing files.
> --
> 2.20.1
How is this to be used with, say, sbuild?
live well,
vagrant
signature.asc
Description: PGP signature
