Source: ladvd
Source-Version: 1.1.2-1
Severity: wishlist
Tags: patch

Hi!

The NetBSD project added some vis function variants, but those had
unfortunately incompatible prototypes with the older OpenBSD ones.
The NetBSD variants are now more widespread though in the BSD world,
and are internally consistent with the other vis functions, so libbsd
upstream will be switching the default variant to the NetBSD one in the
near future.

To avoid breakage we select the OpebBSD variant explicitly to avoid
creating more delta, even though the macro does not exist yet, but
will once the default is switched, so backwards compatibility will
be preserved.

Thanks,
Guillem
From 1b19c638ea8c65425a9e5c4f6e5f34f983b124a8 Mon Sep 17 00:00:00 2001
From: Guillem Jover <guil...@debian.org>
Date: Sat, 9 Jan 2021 21:24:43 +0100
Subject: [PATCH] Define LIBBSD_OPENBSD_VIS to select OpenBSD vis function
 variants

The NetBSD project added some vis function variants, but those had
unfortunately incompatible prototypes with the older OpenBSD ones.
The NetBSD variants are now more widespread though in the BSD world,
and are internally consistent with the other vis functions, so libbsd
upstream will be switching the default variant to the NetBSD one in the
near future.

To avoid breakage we select the OpenBSD variant explicitly to avoid
creating more delta, even though the macro does not exist yet, but
will once the default is switched, so backwards compatibility will
be preserved.
---
 debian/rules | 1 +
 1 file changed, 1 insertion(+)

diff --git a/debian/rules b/debian/rules
index 385c8cc..d637f9f 100755
--- a/debian/rules
+++ b/debian/rules
@@ -5,6 +5,7 @@ DPKG_EXPORT_BUILDFLAGS=1
 DEB_BUILD_MAINT_OPTIONS=hardening=+pie,+bindnow
 -include /usr/share/dpkg/buildflags.mk
 
+CPPFLAGS+=-DLIBBSD_OPENBSD_VIS
 CFLAGS+=$(shell pkg-config --cflags libbsd-overlay)
 LDFLAGS+=$(shell pkg-config --libs libbsd-overlay)
 CFLAGS+=$(shell pkg-config --cflags libbsd-ctor)
-- 
2.30.0

Reply via email to