Hello, I made https://salsa.debian.org/mimi89999/chromium/-/commit/6d21c52698147ca072d223e4e6c2854053319531 and still am waiting for it to build. Is it OK?
Michel Le Bihan Le mercredi 23 décembre 2020 à 14:13 -0600, Boyd Stephen Smith Jr. a écrit : > On Wednesday, December 23, 2020 4:30:48 AM CST Boyd Stephen Smith Jr. > wrote: > > On Wednesday, December 23, 2020 4:19:43 AM CST Michel Le Bihan > > wrote: > > > The Debian patch for #963548 > > > https://salsa.debian.org/mimi89999/chromium/-/blob/ece23b4ca107cd968ac9a40 > > > 9f > > > 40eb11edf8a0266/debian/patches/fixes/serviceworker-double- > > > destruction.pat > > > ch is clearly in upstream 87.0.4280.88: > > > https://source.chromium.org/chromium/chromium/src/+/refs/tags/87.0.4280.88 > > > :c > > > ontent/browser/service_worker/service_worker_container_host.cc;l= > > > 671-679 > > > > Different destructor. The old patch is for > > ServiceWorkerObjectHost, but we > > need a new patch for ServiceWorker*Registration*ObjectHost. > > In particular, just above where you linked to, at line 629 (https:// > source.chromium.org/chromium/chromium/src/+/refs/tags/87.0.4280.88:co > ntent/ > browser/service_worker/service_worker_container_host.cc;l=629) is the > crashing > line. > > The fix for the back trace I finally got is to change that line like > so: > https://source.chromium.org/chromium/chromium/src/+/ > f27ad210062f61d06eb782214ee4fc8c19a1725b:content/browser/service_work > er/ > service_worker_container_host.cc;l=623-647 > > The f27ed21 commit does contain the fix for #963548, but lower down > at line > 689: https://source.chromium.org/chromium/chromium/src/+/ > f27ad210062f61d06eb782214ee4fc8c19a1725b:content/browser/service_work > er/ > service_worker_container_host.cc;l=689-697 >
