On 2020-12-18, Keith Winstein wrote: > Thank you for tracking this down! Happy to take the patch -- would you mind > filing this as an upstream pull request at > https://github.com/ravinet/mahimahi ? That way we will have this in one > place when we next have cycles to upload a new mahimahi package.
I'm not sure an "upstream" patch would make sense in this specific case; in Debian, the most compatible path should be in /bin and /sbin, but this would not necessarily be the case with all distros, and relying on the path detection might actually be appropriate in some cases. So the patch I submitted only modifies debian/rules, not any of the upstream code. An upstream fix *might* be to not embed the full paths at all, and rely a working system PATH, though there may be cases where this does not work... but I am not familiar enough with mahimahi to know if that would be workable. The upstream code that triggers this is the use of AC_PATH_PROG in configure.ac. For what it's worth, it also embeds the path to other binaries through AC_PATH_PROG, but many of those don't change on a Debian usrmerge system. Happy to dialog a little further to sort this out, and thanks for the quick response! live well, vagrant
signature.asc
Description: PGP signature
