Bug#977604: smarty3: broken internal parsetree code

[Mike Gabriel]

Control: forwarded -1 https://github.com/smarty-php/smarty/issues/621

Hi Wolfgang, (hi Uwe),

On  Do 17 Dez 2020 17:48:20 CET, Wolfgang Schweer wrote:

Package: smarty3
Version: 3.1.36-1
Severity: critical
Justification: breaks unrelated software
User:     debian-...@lists.debian.org
Usertags: debian-edu

Hi,

after an upgrade to this version the GOsa² web interface is unusable.
Calling the related URL shows this error:

Fatal error: Uncaught TypeError: Argument 2 passed to
 Smarty_Internal_ParseTree_Template::append_subtree() must be an instance of
 Smarty_Internal_ParseTree, string given, called in
 /usr/share/php/smarty3/sysplugins/smarty_internal_templateparser.php
 on line 2065 and defined in
 /usr/share/php/smarty3/sysplugins/smarty_internal_parsetree_template.php:41

 Stack trace:
 #0
 /usr/share/php/smarty3/sysplugins/smarty_internal_templateparser.php(2065):
 Smarty_Internal_ParseTree_Template->append_subtree()
 #1
 /usr/share/php/smarty3/sysplugins/smarty_internal_templateparser.php(2799):
 Smarty_Internal_Templateparser->yy_r2()
 #2
 /usr/share/php/smarty3/sysplugins/smarty_internal_templateparser.php(2894):
 Smarty_Internal_Templateparser->yy_reduce()
 #3

 Smarty_Internal_Templateparser->doParse()
 #4

 Smarty_Internal_SmartyTemplateCompiler->doCompile()
 #5
  /usr/share/php/smarty3/sysplu in
 /usr/share/php/smarty3/sysplugins/smarty_internal_parsetree_template.php
 on line 41

Downgrading to the previous version makes the error go away, GOsa² is usable.
So this seems to be most probably an issue due to smarty 3.1.36-1.

Wolfgang

/usr/share/php/smarty3/sysplugins/smarty_internal_smartytemplatecompiler.php(128): /usr/share/php/smarty3/sysplugins/smarty_internal_templatecompilerbase.php(481):

I looked into this today and failed to get the issue fixed.



So, I filed an upstream report on this and hope for feedback from Uwe...
https://github.com/smarty-php/smarty/issues/621

Mike


--

DAS-NETZWERKTEAM
c\o Technik- und Ökologiezentrum Eckernförde
Mike Gabriel, Marienthaler Str. 17, 24340 Eckernförde
mobile: +49 (1520) 1976 148
landline: +49 (4351) 850 8940

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de

I tried updating smarty-lexer to upstream's Git master and rebuilt smarty3 3.1.36. Without success...

pgp81Dd8Z43rW.pgp
Description: Digitale PGP-Signatur