Quoting Xavier (2020-12-05 22:34:06) > Le 05/12/2020 à 22:22, Jonas Smedegaard a écrit : > > Package: node-cosmiconfig,jest > > Severity: normal > > > > Both node-cosmiconfig and jest embed Nodejs module callsites. > > > > jest provides it as virtual package node-callsites, > > but jest has a much larger (build-dependency tree. > > > > Please consider shifting to provide node-callsites from node-cosmiconfig. > > > > - Jonas > > Following #976341, callsites is now (will be after ftpmaster review) in > node-jest-debbundle which is small
Yes, small _dependency_ tree - which is certainly an improvement. It still has a large _build-dependency_ tree, however - which means there is a higher risk of accidentally crating circular build-dependencies which is a pain foor bootstrapping new architectures, and there is a higher risk that anything either depending or build-depending on node-callsites gets entangled in transitions or even risk getting kicked out of testing. Even if node-cosmiconfig would need jest for checking build-time tests it would still be helpful to shift: Those bootstrapping would disable test-only build-dependencies (assuming they were correctly annotated with <!nocheck>). Therefore I still suggest to consider shifting which _source_ package contain the embedded modules. Or do you thing I have missed something? Kind regards, - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private
signature.asc
Description: signature