Alright so I've had a go at addressing the issues with mixed results.
I've changed the names of the source and binary packages to what has
been suggested andupdated the Maintainer field to the debian golang
packaging team. I did try to migrate over to using dh-golang as the
buildsystem but I ran into errors such as
can't load package: package
/usr/share/doc/golang-github-grpc-ecosystem-grpc-gateway-dev/examples/gateway:
import
"/usr/share/doc/golang-github-grpc-ecosystem-grpc-gateway-dev/examples/gateway":
cannot import absolute path
and wasn't able to find a solution. I had a look at how arch and fedora
package toolbox and they all used meson, so it seems like that might be
the best way to package it (and I have made a few improvements such as
setting the profile_dir variable) although the biggest problem with it
currently is that it pulls dependencies from github rather then using
what's packaged in the repos. I believe that can be fixed by setting
the GOPATH environment variable but I'm unsure as to what to set it to.
If anyone is able to help, it would be much appreciated.
Many thanks,
Hayley
On Tue, Dec 1, 2020 at 10:54, Hayley Hughes <hayley@foxes.systems>
wrote:
Hey all,
Thanks Raphael for CCing the correct people and thanks to Reinhard
for offering to sponsor.
Would you be happy to maintain the packaging under the golang-team
umbrella or would you have
other preferences? Having it in the debian/ namespace on salsa would
work for me
equally well.
I would be happy to maintain it under the golang team umbrella.
Although it might make things a little easier for them if I changed
it over to using dh_golang to keep things more consistent with other
go packages. I only really chose to go with meson because I needed
something that I knew would just work for the short term.
I agree with Raphael, the currently chosen names are too generic
for integration
into a general-purpose distribution such as Debian. I'd propose:
src:golang-github-containers-toolbox to produce toolbox-podman (or
podman-toolbox)
I definitely agree and will look into fixing everything sometime
today.
Kind regards,
Hayley
On Mon, Nov 30, 2020 at 07:26, Reinhard Tartler <siret...@tauware.de>
wrote:
Thanks Raphael for highlighting Hayley's work.
On 11/30/20 4:22 AM, Raphael Hertzog wrote:
Hi,
On Thu, 22 Oct 2020, Hayley Hughes wrote:
* URL : <https://github.com/containers/toolbox>
Toolbox is a tool that offers a familiar package based
environment for
developing and debugging software that runs fully unprivileged
using Podman.
[…]
I have already made some progress which can be found on salsa
(<https://salsa.debian.org/huggles/toolbox>) for my own benefit
(please feel
free to review it and suggest changes) and I thought that it
might be an
idea to make an attempt to properly package it and add it to the
Debian
archives.
Will be keen to hear what others think.
I was looking for the package and I'm glad that you are working on
packaging it.
I have put in CC Reinhard Tartler and Dmitry Smirnov that are the
Uploaders of podman and buildah, maybe they would be willing to
sponsor
your package and integrate it in the pkg-go team.
I looked at the upstream README and over the packaging, which seems
clean to me.
Curiously, while written in go, it doesn't use the dh_golang
debhelper but
the upstream meson build system. That's a first for me, but
(probably) not concerning.
I'd be happy to upload the package on your behalf.
Would you be happy to maintain the packaging under the golang-team
umbrella or would you have
other preferences? Having it in the debian/ namespace on salsa would
work for me
equally well.
As for the discussion about the package name, podman-toolbox or
container-toolbox looks good to me.
I agree with Raphael, the currently chosen names are too generic for
integration
into a general-purpose distribution such as Debian. I'd propose:
src:golang-github-containers-toolbox to produce toolbox-podman (or
podman-toolbox)
[currently, the packaging uses src:toolbox and toolbox as binary
package name]
Best,
-rt
