Ah, I've been noticing this more on some servers recently, not just my desktop. Possibly a newer ntp finally made it from sid to stable/testing ? Glad we won't have to adjust this manually each time ;)
Cheers, and a schönes Wochenende!

On 27.11.2020 14:35, Axel Beckert wrote:
Control: tag -1 + pending

Hi Maciej,

Axel Beckert wrote:
Maciej Bonin wrote:
> I have noticed that my PC is being flagged as having broken ntp
> settings after the update of ntp to 1:4.2.8p14+dfsg-1 in sid.

Hmmm, didn't notice any issues with my Sid installations. But then
again, I migrated mostly to ntpsec instead of ntp.

Ok, I was able to reproduce this now.

> New ntp version seems to ship with updated ntpq output.

To be more precisely: The positive offsets now sport a leading plus sign.

> I am attaching a patch, but it's a bit of a hatchet job. Please
> check if I didn't change something else unintentionally.

Will have a look, Thanks for the patch!

Didn't apply, but that only seemed whitespace related issues.

Since I wasn't happy with some details (backslash in front of the plus
is unnecessary, the plus is solely needed in the offset column, I made
my own minimal patch for it:

-       } elsif ($line =~ /^\*\S+\s+\S+\s+\d+
\w\s+[\dm-]+\s+[\d-]+\s+[\d-]+\s+([\d\.-]+)\s+([\d\.-]+)\s+([\d\.-]+)/)
{
+       } elsif ($line =~ /^\*\S+\s+\S+\s+\d+
\w\s+[\dm-]+\s+[\d-]+\s+[\d-]+\s+([\d\.-]+)\s+([-\d\.+]+)\s+([\d\.-]+)/)
{

Will be in the next upload which will happen soon.

                Regards, Axel

--
Maciej Bonin <mbo...@phys.ethz.ch>            support: +41 44 633 26 68
IT Services Group, HPT H 8                    voice: +41 44 633 39 97
Department of Physics, ETH Zurich
CH-8093 Zurich, Switzerland                   http://nic.phys.ethz.ch/

Reply via email to