Hi Ferenc On Mon, 09 Nov 2020 00:40:31 +0100 =?utf-8?q?Ferenc_W=C3=A1gner?= <wf...@debian.org> wrote: > Package: debhelper > Version: 12.1.1 > Severity: minor > > Dear Maintainer, > > I was surprised that a daemon start failure during install did not stop > dpkg from exiting with a successful exit status. After much digging I > found https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=766194#22, which > explains the asymmetry with dh_installinit. While I'd find an option > for this more appropriate than different behavior, I also feel like the > current state merits some much more prominent documentation at least. > Please consider addig it to the respective compat level as well.
I'm not sure there is an asymmetry with sysvinit, on the contrary. The "not-fail-on-failures" in dh-systemd (and later dh_installsystemd) was modelled after sysvinit where SysV init scripts typically have an "exit 0" at the end of the init script, thus basically ignoring any error in the init script. systemd/systemctl internally is more strict, that's why we picked the "|| true" approach to mimic the old sysvinit behaviour. Obviously, we could change that to be more picky and abort if a service fails to start. Question is: do we want that? And if so, why? Regards, Michael
signature.asc
Description: This is a digitally signed message part
