On 2020-11-23 13:49:23, Joey Hess wrote: > Antoine Beaupré wrote: >> --- a/etckeeper >> +++ b/etckeeper >> @@ -54,6 +54,10 @@ fi >> if [ ! -z "$AVOID_SPECIAL_FILE_WARNING" ]; then >> export AVOID_SPECIAL_FILE_WARNING >> fi >> +if [ -z "$LANG" ]; then >> + # Default to UTF8 encoding, if unset >> + export LANG=C.UTF-8 >> +fi > > That is rather problimatic, bear in mind that etckeeper can run things > like interactive git commits and editors, which could be translated. > > Also, LANG only influences sort order when LC_COLLATE is not set. > > I guess my commit 4bc7ebe6d29d83df9b86e1be64e696d4d2a70947 upstream > probably fixes whatever this was trying to fix in a better way, although > it's hard to be sure without an explanation of what the actual problem > was. > >> # Make sure sort always sorts in same order. >> -LANG=C >> +LANG=C.UTF-8 > > Why would it matter whether it handles unicode characters or not, if the > point is sort stability?
Those are all good questions, which would be better directed at the original patch author. In other words, I have no idea. :) a. -- Prolétaires de tous les pays, qui lave vos chaussettes? - Audrey Lorde