Source: sugar-calculate-activity
Severity: normal
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: buildpaths
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org

In /usr/share/applications/org.laptop.Calculate.activity.desktop the
build path is embedded, which will presumably not be accessible in the
running system:

  
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/sugar-calculate-activity.html

  171   
Icon·=·/build/1st/sugar-calculate-activity-46/debian/sugar-calculate-activity//usr/share/sugar/activities/Calculate.activity/activity/calculate.svg
     171     
Icon·=·/build/2/sugar-calculate-activity-46/2nd/debian/sugar-calculate-activity//usr/share/sugar/activities/Calculate.activity/activity/calculate.svg

There was a workaround applied to sugar-read-activity in the past, but
it was removed, though it still appears to be necessary. The attached
patch applies this workaround to sugar-calculate-activity.

Ideally, this would be fixed in sugar-toolkit-gtk3
src/sugar3/activity/bundlebuilder.py in the _install_desktop_file
function, but does not appear to be fixed as of 0.117.

live well,
  vagrant
From 2bfe971dc4cb69464efdcf5ef88b49cfdad86cbd Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagr...@reproducible-builds.org>
Date: Sat, 21 Nov 2020 09:52:10 +0000
Subject: [PATCH] Fix embedded build paths in .desktop files.

This fix/workaround originally found in sugar-read-activity history.
---
 debian/rules | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/debian/rules b/debian/rules
index 126a462..b5971b6 100755
--- a/debian/rules
+++ b/debian/rules
@@ -12,3 +12,7 @@ binary-post-install/$(pkg)::
 
 binary-fixup/$(pkg)::
 	find $(cdbs_curdestdir) -type f -name '*.svg' -exec chmod -R -x '{}' \;
+	# Fix broken paths in desktop file
+	#  * TODO: drop when fixed in sugar-toolkit-gtk3
+	find $(cdbs_curdestdir)/usr/share -type f -name '*.desktop' \
+		-execdir perl -pi -e 's,^\S+\s*=\s*\K\S*(?=/usr/share),,g' '{}' ';'
-- 
2.29.2

Attachment: signature.asc
Description: PGP signature

Reply via email to