Source: sugar-read-activity Severity: normal Tags: patch User: reproducible-bui...@lists.alioth.debian.org Usertags: buildpaths X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org
In /usr/share/applications/org.laptop.sugar.ReadActivity.activity.desktop the build path is embedded, which will presumably not be accessible in the running system: https://tests.reproducible-builds.org/debian/rb-pkg/unstable/armhf/diffoscope-results/sugar-read-activity.html 165 Icon·=·/build/1st/sugar-read-activity-123/debian/sugar-read-activity//usr/share/sugar/activities/Read.activity/activity/activity-read.svg 165 Icon·=·/build/2/sugar-read-activity-123/2nd/debian/sugar-read-activity//usr/share/sugar/activities/Read.activity/activity/activity-read.svg There was a workaround applied in the past, but it was removed, though it still appears to be necessary. The attached patch reverts the removal of the workaround. Ideally, this would be fixed in sugar-toolkit-gtk3 src/sugar3/activity/bundlebuilder.py in the _install_desktop_file function, but does not appear to be fixed as of 0.117. live well, vagrant
From aa837521253419d9468c829a0e8772108c359216 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagr...@reproducible-builds.org>
Date: Sat, 21 Nov 2020 09:46:54 +0000
Subject: [PATCH] Fix embedded build paths in .desktop files.
Revert "Stop fix broken paths in desktop file: Fixed in sugar-toolkit-gtk3 since (at least) 0.110.0."
This reverts commit a5ed233b952df6756fbd4709b6450b3734cb2bdb.
It does not appear to be fixed in sugar-toolkit-gtk3 as of 0.117.
---
debian/rules | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/debian/rules b/debian/rules
index 5bd5d22..80fb3bb 100755
--- a/debian/rules
+++ b/debian/rules
@@ -12,3 +12,9 @@ binary-post-install/$(pkg)::
binary-post-install/$(pkg)::
mv debian/$(cdbs_curpkg)/usr/share/locale/aym \
debian/$(cdbs_curpkg)/usr/share/locale/ay
+
+# Fix broken paths in desktop file
+# * TODO: drop when fixed in sugar-toolkit-gtk3
+binary-fixup/$(pkg)::
+ find $(cdbs_curdestdir)/usr/share -type f -name '*.desktop' \
+ -execdir perl -pi -e 's,^\S+\s*=\s*\K\S*(?=/usr/share),,g' '{}' ';'
--
2.29.2
signature.asc
Description: PGP signature
