On Fri, Feb 14, 2020 at 06:42 PM, Sadie Powell wrote:
> Package: inspircd
> Version: 3.4.0-2
> 
> Hello,
> 
> We have received reports that users of your package are experiencing errors  
> caused by Debian patching the httpd module to not use the vendored version of 
> the http_parser library.
> 
> Having had a look at the patch (debian.use-http-parser-lib.patch) it seems 
> like your patch is forgetting to link against the library so the module is 
> compiling but failing at runtime.

Thank you for the report! I've fixed the patch to ask the linker to link
the library.

> 
> Ideally the fix for this should be to just remove this patch. We only test 
> against the vendored version and there's no guarantee we won't make changes 
> to the vendored libraries which make them incompatible with the mainline 
> version. It's only a tiny library with no external dependencies so this isn't 
> harmful at all.

In general Debian's default approach is not to ship vendored libraries,
are the tests you mentioned something that gets run at build time?

Debian's autopkgtest runs tests with a full system instead, so we could
test loading the module and run higher level tests.

Filippo

Reply via email to