Antoine Beaupré wrote: > On 2017-09-28 12:37:38, Jack Bates wrote: >> I think the following will resolve this, by running the diff-highlight >> Makefile when the package is built (following the pattern in >> debian/rules for other contrib things): >> >>> diff --git a/debian/rules b/debian/rules >>> index f132a2605..ea018298b 100755 >>> --- a/debian/rules >>> +++ b/debian/rules >>> @@ -58,6 +58,7 @@ build-stamp: >>> override_dh_auto_build-arch: build-stamp >>> $(MAKE) -C contrib/subtree all $(OPTS) >>> ln -s contrib/subtree/git-subtree >>> + $(MAKE) -C contrib/diff-highlight $(OPTS) >>> >>> override_dh_auto_test-arch: >>> test -z '$(TEST)' || \ > > Any reason why this hasn't been applied to the package just yet? > > I'd be happy to do that in a NMU if there are no objections...
Please don't. Adding additional contrib/ code to the supported surface without coordination is not an NMU I'd welcome at all (instead, it would be a bit of a rude shock). Would it make sense to install this to /usr/share/git-core/contrib/? If not, could it go in a separate package (within the same source package)? I'm also curious about how this compares to https://pypi.org/project/diff-highlight/ Thanks, Jonathan
