tags 971986 fixed-upstream pending
thanks

This was fixed upstream in <https://gerrit.wikimedia.org/r/c/mediawiki/core/+/632910> which should be included in the next maintenance/security release.

-- Kunal

On 10/11/20 12:38 AM, Alain Knaff wrote:
Package: mediawiki
Version: 1:1.31.10-1~deb10u1

Hi,

The localSettings variable $wgRedirectOnLogin is ignored, apparently because the showReturnToPage function forgot to declare it global. This results in an unsightly warning in the web server log:

[Sun Oct 11 09:29:12.186114 2020] [proxy_fcgi:error] [pid 14121:tid 139621415540480] [client 80.90.57.94:38882] AH01071: Got error 'PHP message: PHP Notice:  Undefined variable: wgRedirectOnLogin in /usr/share/mediawiki/includes/specials/helpers/LoginHelper.php on line 68', referer: https://wiki.lll.lu/Special:UserLogin?returnto=HomePage


Adding the following to the top of the showReturnToPage in /usr/share/mediawiki/includes/specials/helpers/LoginHelper.php fixes the issue:
   global $wgRedirectOnLogin;


Thanks,

Alain


Reply via email to