Hi!

On Fri, 2020-09-25 at 20:44:54 +0200, Daniel Leidert wrote:
> Control: reopen 970762
> 
> Am Mittwoch, den 23.09.2020, 03:13 +0200 schrieb Guillem Jover:
> > ---
> > commit c2c28549a513b93898d8c49f6eb8cefc1670a1e2
> > Author: Guillem Jover <guil...@debian.org>
> > Date:   Wed Sep 23 03:00:35 2020 +0200
> > 
> >     Force the hardlink for the backup pci.ids database in update-pciids
> >     
> >     Closes: #970762, #970762
> 
> This patch only fixes the creation of the hardlink of pci.ids.gz.old ->
> pci.ids.gz, which btw seems really odd to me (why do we need this link?
> shouldn't .old be or at least link to the previous database?).

The hardlink is used to make a backup, then the destination file gets
replaced with the new database.

> However /usr/share/misc/pci.ids is still deleted and breaks virt-manager.
> 
> I was checking the script and it seems it fails somwhere at lines 52-60. If I
> print out the commands it looks like this:

Ugh, sorry completely missed this in the original report. :(

I've checked the code, and it seems there are several wrong things,
which I'll be fixing. First the PCI_IDS defaults to the compressed
file, but the pci.ids.deb ships an uncompressed one. Then the script
conflates the format that it downloads from, but does not cover what
it should write it to.

> Reopening report.

Thanks, will fix this tomorrow.

Regards,
Guillem

Reply via email to