Package: src:intelrdfpmath
Version: 2.0u2-2
Severity: minor
Tags: patch

Dear Maintainer,

At 3 places, the abs() function is used without being declared, resulting in
messages like the following one:

 src/bid64_pow.c: In function ‘__bid64_pow’:
 src/bid64_pow.c:183:17: warning: implicit declaration of function ‘abs’ 
[-Wimplicit-function-declaration]
   183 |       exact_y = abs(exact_y);

Fortunately, the compiler should infer the correct prototype in this case. It’s
however better to avoid such a situation (which is forbidden in C99 and C11,
though GCC does not enforce that rule by default).

I attach a patch.

Thanks for your work,

--
⢀⣴⠾⠻⢶⣦⠀  Sébastien Villemot
⣾⠁⢠⠒⠀⣿⡁  Debian Developer
⢿⡄⠘⠷⠚⠋⠀  http://sebastien.villemot.name
⠈⠳⣄⠀⠀⠀⠀  http://www.debian.org
Description: Ensure that abs() is not used without being declared
Author: Sébastien Villemot <sebast...@debian.org>
Bug-Debian: https://bugs.debian.org/<TO_BE_COMPLETED>
Forwarded: no
Last-Update: 2020-09-23
---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
--- a/LIBRARY/src/bid128_pow.c
+++ b/LIBRARY/src/bid128_pow.c
@@ -27,6 +27,7 @@
   THE POSSIBILITY OF SUCH DAMAGE.
 ******************************************************************************/
 
+#include <stdlib.h>
 #include "bid_trans.h"
 
 static BID_UINT128 BID128_0 = {BID128_LH_INIT( 0x0000000000000000ull, 
0x3040000000000000ull )};
--- a/LIBRARY/src/bid32_pow.c
+++ b/LIBRARY/src/bid32_pow.c
@@ -28,6 +28,7 @@
 ******************************************************************************/
 
 
+#include <stdlib.h>
 #include "bid_internal.h"
 
 #define BID32_NAN 0x7c000000ul
--- a/LIBRARY/src/bid64_pow.c
+++ b/LIBRARY/src/bid64_pow.c
@@ -28,6 +28,7 @@
 ******************************************************************************/
 
 
+#include <stdlib.h>
 #include "bid_trans.h"
 
 #define BID64_0 0x31c0000000000000ull

Reply via email to