Source: nspr
Version: 4.28-1
Severity: important
Tags: patch
User: n...@packages.debian.org
Usertags: linux-any

Hello,

In debian/rules the runtests.sh script is not run properly. The line

cd nspr/pr/tests && grep -v
'^\(fdcach\|gethost\|getproto\|nblayer\|peek\|socket\|vercheck\)$$'
./runtests.sh | sh - $(CURDIR)/nspr/dist

needs to change to

cd nspr/pr/tests && grep -v
'^\(fdcach\|gethost\|getproto\|nblayer\|peek\|socket\|vercheck\)' ./runtests.sh
| sh -s - $(CURDIR)/nspr/dist

Note that only fdcach and peek tests are activated in runtests.sh, all other
tests are already commented out in that file, so the above line can be
significantly reduced. 

Attached is a patch to fix this together with the tests for GNU/Hurd, reported
in #970659: debian_rules.diff.

Thanks!
--- a/debian/rules	2020-09-20 17:11:23.000000000 +0200
+++ b/debian/rules	2020-09-20 18:26:34.000000000 +0200
@@ -84,7 +84,12 @@
 	# Skip socket because it freezes.
 	# Skip getproto because it fails on some buildds.
 	# Skip nblayer because it freezes on armel.
+ifneq (hurd,$(shell dpkg-architecture -qDEB_HOST_ARCH_OS))
-	cd nspr/pr/tests && grep -v '^\(fdcach\|gethost\|getproto\|nblayer\|peek\|socket\|vercheck\)$$' ./runtests.sh | sh - $(CURDIR)/nspr/dist
+	cd nspr/pr/tests && grep -v '^\(fdcach\|peek\)' ./runtests.sh | sh -s - $(CURDIR)/nspr/dist
+else
+	# Skip semaphore tests: not implemented on GNU/Hurd.
+	cd nspr/pr/tests && grep -v  '^\(sema\|semaerr\|semaping\)' ./runtests.sh | sh -s - $(CURDIR)/nspr/dist
+endif
 	cd nspr/lib/tests && LD_LIBRARY_PATH=$(CURDIR)/nspr/dist/bin$(addprefix :,$(LD_LIBRARY_PATH)) ./base64t
 	cd nspr/lib/tests && LD_LIBRARY_PATH=$(CURDIR)/nspr/dist/bin$(addprefix :,$(LD_LIBRARY_PATH)) ./string
 endif

Reply via email to