Hi Tiago, hi Julian, On Fri, Sep 18, 2020 at 01:13:55PM -0300, Tiago Daitx wrote: > Hi Tony, > > Matthias is the actual Debian Maintainer, but in my opinion the patch > is great and should be ok to go do an upload including it.
Yes, that's a good point. Once the upload is ready (see below), I will upload it as an NMU to the delayed queue if we haven't heard back from Matthias. > > > On Thu, Sep 17, 2020 at 06:45:39PM +0100, Julian Gilbey wrote: > > > > affects 944738 openjdk-14-jdk > > > > thanks > > > > > > > > The same problem is still present in openjdk-14 - see > > > > https://bugs.debian.org/968991 > > > > > > I have located the source of the bug and have a patch to fix it. > > > > > > The cause is the use of dh_strip_nondeterminism late in the build > > > process. This reorganises the jmod files, which in turn changes their > > > SHA256 checksums. This would not be a problem, except that the > > > checksums are saved in java.base.jmod *before* the use of > > > dh_strip_nondeterminism. Performing this stripping immediately after > > > each jmod file is created results in the checksums being consistent > > > throughout. Julian, I applied the patch and built the package successfully, but jlink still fails with the "expected hash" error. It's (perhaps) interesting that the expected hash does differ between the patched build and the unpatched build. Disabling the invocation of 'dh_strip_nondeterminism -a' in debian/rules *does* address the problem with jlink, either with or without the jmod patch applied. Also, I had to add strip-determinism to the build-deps to build with the patch. Given that the package doesn't build reproducibly anyway, my inclination is to make the change in debian/rules to address this long-standing bug. Thanks, tony
signature.asc
Description: PGP signature
