found 960132 4.1-1
severity 960132 serious

Justification for "serious":

This bug causes a shipped service (mdcheck_start.service) to completely
fail to start, due to the fact that its script
(/usr/share/mdadm/mdcheck) does not exist. A package should not release
in that state.

I considered going up or down a level, but ultimately landed on "serious".

Argument for increasing to "grave":

For someone expecting/needing this service to work, this could lead to
data loss. The entire point of MD's "check" functionality is to make
sure that all the blocks are readable. In e.g. a two-disk mirror, if one
disk ends up with an unreadable block and then the other disk fails,
data loss occurs. If the check script runs as intended and catches this
before the second failure, the unreadable block will be detected and
then rewritten (from the good copy on the other disk).

Argument for decreasing to "important":

mdcheck_start.timer is disabled by default and /etc/cron.d/mdadm still
exists.


Regardless of the particular severity (>= important), I think this is a
good candidate for a stable update. Here is an example debdiff (sub in
your name):

--- mdadm-4.1/debian/changelog  2019-01-15 12:23:53.000000000 -0600
+++ mdadm-4.1/debian/changelog  2020-09-18 02:09:41.000000000 -0500
@@ -1,3 +1,9 @@
+mdadm (4.1-1+deb10u1) buster; urgency=medium
+
+  * Install misc/mdcheck (Closes: #960132)
+
+ -- Richard Laager <rlaa...@debian.org>  Fri, 18 Sep 2020 02:09:41 -0500
+
 mdadm (4.1-1) unstable; urgency=medium

   * New upstream release.
diff -Nru mdadm-4.1/debian/rules mdadm-4.1/debian/rules
--- mdadm-4.1/debian/rules      2019-01-15 12:23:53.000000000 -0600
+++ mdadm-4.1/debian/rules      2020-09-18 02:08:04.000000000 -0500
@@ -64,6 +64,7 @@
        install -Dm0755 debian/mkconf $(DESTDIR)/usr/share/mdadm/mkconf
        install -Dm0755 debian/checkarray $(DESTDIR)/usr/share/mdadm/checkarray
        install -Dm0755 debian/bugscript $(DESTDIR)/usr/share/bug/mdadm/script
+       install -Dm0755 misc/mdcheck $(DESTDIR)/usr/share/mdadm/mdcheck
        install -Dm0755 udeb/mdadm $(DESTDIR_UDEB)/sbin/mdadm
        install -Dm0755 udeb/mdmon $(DESTDIR_UDEB)/sbin/mdmon
        install -Dm0644 $(DESTDIR)/lib/udev/rules.d/63-md-raid-arrays.rules
$(DESTDIR_UDEB)/lib/udev/rules.d/63-md-raid-arrays.rules

-- 
Richard

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to