Greetings!
Thanks for all the comments.
That's quite a lot of needed fixes; I guess that's why mentors
exists :)
On Tue, 2020-09-08 at 22:01 +0200, Tobias Frost wrote:
> Control: tags -1 moreinfo
>
> Hi Francisco,
>
> On Sat, 29 Aug 2020 17:16:50 -0300 Francisco M Neto <fmn...@gmail.com> wrote:
> > Package: hydrapaper
> > Version: 1.12-1
>
> Upstream has released 2.0 in the meantime. Can you update it please?
Will do.
> I: hydrapaper source: quilt-patch-missing-description 010_fix-quotation-marks-
> in-fstring.patch
> - the patch does not have dep3 headers. Have you sent the patch upstream?
I did. And I remember creating that header; I probably made some mistake
when committing.
> d/copyright:
> - 1st files section says License: GPL3+, but License text says "Version 2" at
> two locations.
> - Usually it is best to have the same license for the debian/* part as
> upstream. If you make the debian/* GPL3+, d/copyright can become even
> shorter.
> (Yes, GPL2+ includes GPL3+, but the version 2 is moot in combination)
Interesting; I hadn't thought about that!
> d/control:
> Build Depends on cmake and meson. Does it need both?
> The list on Build-Depends on the README.md is shorter than in d/control.
> Please re-check your B-Ds if they are really needed.
Something in the source tree made me believe I'd need both; I'll recheck
that.
> d/watch has some extra lines.
> d/watch could be more elegant, see https://wiki.debian.org/debian/watch#Gitlab
> i.e.
> version=4
> https://gitlab.com/gabmus/HydraPaper/tags?sort=updated_desc
> archive/@ANY_VERSION@/HydraPaper-\d\S*@ARCHIVE_EXT@
Nothing to say here; this is more elegant, I suppose I got a little
paranoid with the regexps.
> (Noting here that your orig source tarball is tar.xz, but upstream has no
> tar.xz… How did you create the orig.xz tarball? Please stick to the upstream
> provided one…)
That orig tarball was generated automagically, probably when I imported
the upstream source... I'm not sure why it was generated like that. I didn't see
a tag when I ran lintian so I didn't notice it.
> Nitpicks:
> There is no need to override maintainer-manual-page. Overrides should not be
> used to silence lintian, but only if lintian is wrong.
> However, if you override you should provide more information in the override,
> like the MR where the manpage can be found.
> But ASFAIS the next release will have the manpage, so no need for action.
That tag kept triggering my OCD; but I get your point - overrides should
be meaningful.
Thank you very much for all the comments!
--
[]'s,
Francisco M Neto <fmn...@fmneto.com>
www.fmneto.com
3E58 1655 9A3D 5D78 9F90
CFF1 D30B 1694 D692 FBF0
signature.asc
Description: This is a digitally signed message part
