On Tue, 2020-08-25 at 14:58:15 +0200, Jakub Wilk wrote:
> * Guillem Jover <guil...@debian.org>, 2020-08-25, 11:26:
> > This seems to be an increasing regression in make:
> 
> I don't belive it is.

Indeed! Sorry bad testing procedure from my side.

> >  $ cat a.mk
> >  include /usr/share/dpkg/architecture.mk

This should have been instead something like:

  include scripts/mk/architecture.mk

> >  all:
> >     true
> >  (sid)$ time make -f a.mk
> >  real    0m0.824s
> >  user    0m0.702s
> >  sys     0m0.131s
> >  (buster)$ time make -f a.mk
> >  real    0m0.396s
> >  user    0m0.351s
> >  sys     0m0.054s
> 
> Hmm, I don't see any significant difference in speed between buster and sid
> chroots here. (Though curiously they are about twice as fast as my normal
> sid system.)

This seems to have been caused by commit
f6e152b63f9eb183313807898be0569f5321bdf6. So now I'm a bit conflicted,
because that change still make sense. And while the slow down should
not really be visible when building with dpkg-buildpackage as the vars
would then be pre-set, it defeats the point of the lazy logic there.

So I guess I'll move to adding a new --export-make or similar.

Thanks,
Guillem

Reply via email to