Source: ubuntu-dev-tools Version: 0.154 Severity: minor Tags: patch Hi,
Thanks a lot for maintaining ubuntu-dev-tools! What do you think about the attached trivial patch that avoids outputting a slightly confusing message containing empty strings if a target architecture is not specified at all? Thanks again, and keep up the great work! G'luck, Peter -- System Information: Debian Release: bullseye/sid APT prefers testing APT policy: (990, 'testing'), (500, 'testing-debug') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 5.7.0-2-amd64 (SMP w/8 CPU threads) Locale: LANG=bg_BG.UTF-8, LC_CTYPE=bg_BG.UTF-8 (charmap=UTF-8), LANGUAGE not set Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled -- no debconf information
From a3c2cde7f66c292089cb2f78e870ac6080e25dd4 Mon Sep 17 00:00:00 2001
From: Peter Pentchev <r...@debian.org>
Date: Wed, 12 Aug 2020 22:58:54 +0300
Subject: [PATCH] Fix a check for TARGET_ARCH in a message.
---
mk-sbuild | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mk-sbuild b/mk-sbuild
index bf3c68e..c50fdb3 100755
--- a/mk-sbuild
+++ b/mk-sbuild
@@ -915,7 +915,7 @@ echo ""
echo " To CHANGE the golden image: sudo schroot -c source:${CHROOT_NAME} -u
root"
echo " To ENTER an image snapshot: schroot -c ${CHROOT_NAME}"
echo " To BUILD within a snapshot: sbuild -A -d ${CHROOT_NAME} PACKAGE*.dsc"
-if [ "$CHROOT_ARCH" != "$TARGET_ARCH" ] ; then
+if [ -n "$TARGET_ARCH" ] && [ "$CHROOT_ARCH" != "$TARGET_ARCH" ] ; then
echo " To BUILD for ${TARGET_ARCH}: sbuild -A -d ${CHROOT_NAME} --host
${TARGET_ARCH} PACKAGE*.dsc"
fi
echo ""
--
2.28.0
signature.asc
Description: PGP signature
