Hi Steffen and Antoni,
On Wed, Jul 29, 2020 at 11:10:40PM +0200, Steffen Möller wrote:
> Hi Antoni,
>
> had a look at [0] and liked it. @Andreas [who has worked on the package
> prior to your commits], ping me if you want me to proceed.
I pinged again
https://github.com/MikkelSchubert/paleomix/issues/15
I admit I feel a bit blocked by the fact that upstream is promising
a new Python3 only version and is not happy about our Python2 to
Python3 conversion code of the old version. Feel free to decide -
I'm not using this program and can not decide what might be the best
in the interest of our users.
> What I am
> tempted to comment on:
>
> - the python3-setuptools I would have left at the top since this is
> something "meta" that does not describe what the package is
> implementing, but ... hey ... I may be wrong here, alphabetical as you
> have it is just as fine
I admit I put usually python3-setuptools on top but I would not question
any other good reason to move it somewhere else. IMHO it would be the
best idea if dh-python would simply depend from python3-setuptools and
we could leave it out generally since its needed in nearly all Python
packages anyway.
> - I was impressed by the sed to get the paths right for testing. The
> difficulty is with the increased complexity of the packaging. In
> pre-Covid-19 times I typically sent pull requests upstream whenever
> possible to avoid shifts in complexity to impede with the maintenance of
> the Debian packages. With you all around, though, and to get it all into
> the distribution as quickly and well-tested as possible, I am just as happy.
I confirm that I'm happy as well! :-)
> So - thank you tons! Approved from my side.
In short: I'm fine if someone decides its ready to upload and we
can migrate to official Paleomix with Python3 later.
Kind regards
Andreas.
--
http://fam-tille.de
