On Sun, Jun 28, 2020 at 2:36 AM Boian Bonev wrote: > iotop-c - simple top-like I/O monitor (implemented in C)
I am willing to sponsor this. Some issues that I think need to be fixed before uploading: Please comply with Debian Policy about build verbosity: https://www.debian.org/doc/debian-policy/ch-source.html#main-building-script-debian-rules Please fix these lintian warnings: I: iotop-c: hardening-no-bindnow usr/sbin/iotop-c Please fix the cppcheck warning-level complaints. While looking at the pw_name warning, I noticed that the same pattern occurs in both view_batch and view_curses but cppcheck doesn't detect the two occurrences in view_curses for some reason. Some issues that would be nice to fix: I know that GNU Make has some default rules that could make most of the Makefile unnecessary, but I wonder if other Make implementations also have enough of them so that you could actually rely on the default rules. Please wrap and sort the debian/ packaging files, this makes packaging diffs easier to read. wrap-and-sort --short-indent --wrap-always --sort-binary-packages --trailing-comma Please include copyright holder information and license grants in each of the source files. SPDX is a standard machine-readable way to do that. https://lu.is/blog/2012/03/17/on-the-importance-of-per-file-license-information/ https://spdx.org/ Please replace COPYING with the canonical version of the GPLv2: https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt Please fix any of the easy-to-fix lintian complaints. I'm not sure what is correct for the conflicts, but you could test using piuparts if using breaks is enough or if using conflicts is really needed. I assume you'll want to keep debhelper compat 12 for backportability. Look up the tag names on lintian.d.o or using `lintian-info -t` for descriptions of the tags. I: iotop-c: conflicts-with-version iotop (<= 0.6-24-g733f3f8-1) I: iotop-c source: debian-watch-contains-dh_make-template <project> I: iotop-c source: testsuite-autopkgtest-missing X: iotop-c source: debian-watch-does-not-check-gpg-signature P: iotop-c source: maintainer-manual-page debian/iotop-c.alternatives-dh13.1 P: iotop-c source: maintainer-manual-page debian/iotop.8 P: iotop-c source: package-uses-old-debhelper-compat-version 12 X: iotop-c source: upstream-metadata-file-is-missing The following tools run by check-all-the-things produce some probably actionable complaints: blhc mandoc wrap-and-sort cppcheck -- bye, pabs https://wiki.debian.org/PaulWise
