Bug#963602: gftl: please make the build reproducible

[Chris Lamb]

Source: gftl
Version: 1.2.5-1
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
gftl could not be built reproducibly.

This is because it calls out to m4 during the build with the
--synclines/-s argument, resulting in absolute filenames in the
generated files:

  │ │ │ -#line 1 "/build/1st/gftl-1.2.5/include/types/../templates/header.m4"
  │ │ │ +#line 1 "/build/2/gftl-1.2.5/2nd/include/types/../templates/header.m4"

Patch attached that drops these "-s" arguments.


 [0] https://reproducible-builds.org/


Regards,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      la...@debian.org / chris-lamb.co.uk
       `-
--- a/debian/patches/Reproducible-build.patch   1970-01-01 01:00:00.000000000 
+0100
--- b/debian/patches/Reproducible-build.patch   2020-06-24 10:25:46.192857080 
+0100
@@ -0,0 +1,26 @@
+Description: Make the build reproducible
+Author: Chris Lamb <la...@debian.org>
+Last-Update: 2020-06-24
+
+--- gftl-1.2.5.orig/include/templates/CMakeLists.txt
++++ gftl-1.2.5/include/templates/CMakeLists.txt
+@@ -30,7 +30,7 @@ foreach( macro_file ${macro_files} )
+ 
+     add_custom_command (
+       OUTPUT ${outfile}
+-      COMMAND m4 -s -Dparam=${param} -I${src}/../templates < ${infile} > 
${outfile}
++      COMMAND m4 -Dparam=${param} -I${src}/../templates < ${infile} > 
${outfile}
+       WORKING_DIRECTORY ${bin}
+       DEPENDS ${infile}
+       )
+--- gftl-1.2.5.orig/include/types/CMakeLists.txt
++++ gftl-1.2.5/include/types/CMakeLists.txt
+@@ -46,7 +46,7 @@ foreach (macro_file ${macro_files})
+ 
+     add_custom_command (
+       OUTPUT ${outfile}
+-      COMMAND m4 -s -Dparam=${param} -I${src}/../templates < ${infile} > 
${outfile}
++      COMMAND m4 -Dparam=${param} -I${src}/../templates < ${infile} > 
${outfile}
+       WORKING_DIRECTORY ${bin}
+       DEPENDS ${infile}
+       )
--- a/debian/patches/series     2020-06-24 10:06:35.650534804 +0100
--- b/debian/patches/series     2020-06-24 10:25:45.024845254 +0100
@@ -1,2 +1,3 @@
 Install-files-in-standard-Debian-paths.patch
 Fixes-96-Eliminate-extraneous-includes.patch
+Reproducible-build.patch