Source: golang-v2ray-core
Version: 4.23.4+ds-2
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
golang-v2ray-core could not be built reproducibly.

This is because during the test part of the build process the package
generates test certificates that end up in the final binary .deb.

This is a problem in two ways: these files are not deterministic
(DSA-1571 was a long time ago) and the contents of the package will
depend on whether you run the testsuite or not (ie. with "nocheck"
etc.)

Patch attached that never installs these files.

 [0] https://reproducible-builds.org/


Regards,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      la...@debian.org / chris-lamb.co.uk
       `-
--- a/debian/rules      2020-06-23 10:13:48.027577661 +0100
--- b/debian/rules      2020-06-23 10:25:47.206848028 +0100
@@ -20,5 +20,8 @@
        DH_GOPKG="v2ray.com/core/infra/control/main" dh_auto_build -- -ldflags 
"$(LDFLAGS)" -tags confonly
        cd obj-$(DEB_HOST_GNU_TYPE); mv bin/main bin/v2ctl
 
+override_dh_install:
+       dh_install -X.pem
+
 %:
        dh $@ --buildsystem=golang --with=golang

Reply via email to