22.06.2020 07:26, Vagrant Cascadian wrote: ... > -RELEASE="$(USER)@$(HOSTNAME) release $(shell cat ../VERSION)" > +RELEASE="release $(shell cat ../VERSION)"
Here and in other similar places, how about using RELEASE=... explicitly in the parent makefile (which is d/rules) instead of patching? I dunno, I'm just a bit dislike patching and prefer to override a variable like this if it's possible. Patch is good in a way that it works as long as the problem place stays the same, - so that if anything there changes (including the case when the patch isn't needed anymore), we'll have to revisit it at least. Somewhat similar is the situation with LC_* variables, - sometimes I just export LC_ALL=C in the top of d/rules and be done with it, after that I don't care how well the upstream build system deals with various intl. stuff. Note that sometimes non-C locale might expose difficult to debug bugs, - for example, in the C locale the order of upper- and lower-case letters (first all uppercase next all lowercase) is different than in some other locales, like in RU, where upper and lower-case is intermixed (first Aa, next Bb etc), - so when doing thigs like $(ls -1 | head ..) we might have entirely different results. What do you think? And thank you for debugging all this! /mjt
