On 2020-06-21, John Franklin wrote: > While using simple-cdd this weekend, I discovered a few things about the disk > image used with qemu-based testing.
Thanks for submitting! > The simple-cdd.conf.detailed file documents two settings for the disk image: > hd_img and hd_size. These two settings are ignored by simple-cdd. > > The default disk is a qcow image with the name qemu-test.hd.img stored in the > project root. There are four improvements I'd like to make here: > > > * Change this to a qcow2 format to open up additional capabilities of the > qcow2 > format. This may also improve performance (untested). Sounds good. > * Change the name to qemu-test.hd.qcow2 to make it more obvious to a developer > what the file is and its format. I'd prefer not to change the filename, as then it would have to be changed whenever the file format changes. > * Move the file to the $simple_cdd_tmp folder, in a qemu subfolder, to better > organize it with the rest fo the temporary build files. Mixed feelings on this; wondering if it wouldn't make sene to go into the images folder instead. Or maybe $simple_cdd_tmp is fine. > * Change the script to use qemu's -drive option to improve the speed of the > disk emulation. With the existing -hda setting, even simple tests take hours > to complete, whereas -drive with some extra options reduces it to a couple > minutes. Great! > The PR at https://salsa.debian.org/debian/simple-cdd/-/merge_requests/2 > addresses all of the above issues: Thanks! > * Honor hd_img and hd_size, if they're set. Overall, looks good! It does seem to change commented out example size, which doesn't seem necessary, it only being an example? I think I had put an example in there which was a non-default value for qemu-img at the time... but in general I'd like to keep the defaults to whatever qemu-img spits out. > * Change default hd_img format and extension to qcow2. As mentioned above, fine with changing the format, but would rather not change the filename extension. > * Use -drive instead of -hda for more options and performance. Sounds good; this project was started 15+ years ago and it shows! :) > * If hd_img isn't an absolute path, store it in tmp/qemu. Mixed feelings on that, as mentioned above. Happy to merge most of it; could you re-write the git history so that the contested points are in separate commits? Then I can merge the uncontested patches while we sort out the remainder. live well, vagrant
signature.asc
Description: PGP signature
