Bug#963212: lintian: False positive for no-dh-sequencer when command prefix is used

[Rafael Laboissière]

Package: lintian
Version: 2.80.0
Severity: normal
Tags: patch

Dear Maintainer,

I stumbled upon a debian/rules like this:

    #!/usr/bin/make -f
    %:
            +dh $@ --buildsystem=octave --with=octave

for which the Lintian warning no-dh-sequencer is wrongly triggered.  The 
root of the problem is a regular pattern in dh-sequencer.pm that does not 
take into account Makefile's command prefixes.  The trivial patch 
attached to this bug report fixes the problem.

Best,

Rafael Laboissière

diff --git a/checks/debian/rules/dh-sequencer.pm b/checks/debian/rules/dh-sequencer.pm
index afddfbf37..31f2ad803 100644
--- a/checks/debian/rules/dh-sequencer.pm
+++ b/checks/debian/rules/dh-sequencer.pm
@@ -53,7 +53,7 @@ sub source {
     my $rule_target = qr/(?:$rule_altern|'$rule_altern'|"$rule_altern")/;
 
     $self->tag('no-dh-sequencer')
-      unless $contents =~ /^[^:]+:[^ \t]*\n\t+dh[ \t]+$rule_target/m
+      unless $contents =~ /^[^:]+:[^ \t]*\n\t+(\+|@|-)?dh[ \t]+$rule_target/m
       || $contents =~ m{^\s*include\s+/usr/share/cdbs/1/class/hlibrary.mk\s*$}m
       || $contents =~ m{\bDEB_CABAL_PACKAGE\b};