Hi Ritesh

Thanks for looking into it! Much appreciated! 

In my undestanding the fixes applied as per pull rquest 172[1]
enforces to guarantee that permissions are always set on safe side,
which is not yet present in the version shipped in Debian.

 [1] https://github.com/open-iscsi/targetcli-fb/pull/172

I did on my test environment following as well to double check:

root@sid:~# umask
0022
root@sid:~# apt-get install targetcli-fb
[...]
root@sid:~# ls -la /etc/rtslib-fb-target/
total 20
drwxr-xr-x   3 root root  4096 Jun  7 10:19 .
drwxr-xr-x 112 root root 12288 Jun  7 10:19 ..
drwxr-xr-x   2 root root  4096 Aug  2  2019 backup
root@sid:~#

Now

root@sid:~# targetcli 
targetcli shell version 2.1.fb49
Copyright 2011-2013 by Datera, Inc and others.
For help on commands, type 'help'.

/> status
Status for /: 
/> exit
Global pref auto_save_on_exit=true
Configuration saved to /etc/rtslib-fb-target/saveconfig.json
root@sid:~# ls -la /etc/rtslib-fb-target/
total 24
drwxr-xr-x   3 root root  4096 Jun  7 10:20 .
drwxr-xr-x 112 root root 12288 Jun  7 10:19 ..
drwxr-xr-x   2 root root  4096 Aug  2  2019 backup
-rw-r--r--   1 root root    69 Jun  7 10:20 saveconfig.json
root@sid:~#

So I think the problem was not only introduced later upstream, at
least as well double-checking what the code does, the permissions are
not enforced. But maybe I still miss something.

Regards,
Salvatore

Reply via email to