reassign 345563 scrollkeeper reassign 352628 scrollkeeper severity 352714 grave merge 345563 352628 352714 thanks
There are two release critical bugs against yelp (352628 and 345563). Based on comments to those bugs they are really bugs in scrollkeeper, and I've verified this by testing. Thus I'm reassigning them. The same bug is already reported as a normal-severity bug against scrollkeeper, so I'm raising its severity and merging. The bug logs also include a reference to a patch that fixes the problem. I've verified the fix, both by code review and testing, and am including the patch with which I intend to NMU to fix the bug.
=== added file 'debian/patches/08_libs_i18n_c_malloc_bug.diff' --- /dev/null +++ debian/patches/08_libs_i18n_c_malloc_bug.diff @@ -0,0 +1,11 @@ +--- scrollkeeper-0.3.14.untouched/libs/i18n.c 2003-11-09 23:05:36.000000000 +0000 ++++ scrollkeeper-0.3.14/libs/i18n.c 2006-04-08 18:48:09.000000000 +0000 +@@ -206,7 +206,7 @@ + count++; + } + +- tab = (char ***)malloc(sizeof(char **) * count); ++ tab = (char ***)malloc(sizeof(char **) * (count + 1)); + + str = strdup(lang); + check_ptr(str, ""); === modified file 'debian/changelog' --- debian/changelog +++ debian/changelog @@ -1,3 +1,22 @@ +scrollkeeper (0.3.14-10.1) unstable; urgency=low + + * Non-maintainer upload. + Note that although #352714 against scrollkeeper is of severity + "normal", #352628 and #345563 against yelp are release critical, + which is justification for the NMU. + * Applied patch, with a modification to surround the addition with + parentheses, from + http://librarian.launchpad.net/1510562/scrollkeeper.patch (see also + https://launchpad.net/distros/ubuntu/+source/yelp/+bug/18434). This + fixes a memory allocation that is one array element too small. Note + that the original patch only adds one byte, but we need enough for + one char**. As it happens, adding just one byte will work, since + malloc rounds up to the next suitable multiple of word size (or + even larger unit), but it is not correct to rely on this. + Closes: #352714, #352628, #345563. + + -- Lars Wirzenius <[EMAIL PROTECTED]> Sat, 8 Apr 2006 18:47:42 +0000 + scrollkeeper (0.3.14-10) unstable; urgency=medium * [debian/patches/00_updated_translations.diff] Reordered from
