Control: severity -1 grave On Sun, 31 May 2020 18:03:01 +0200, Bernhard Übelacker <bernha...@mailbox.org> wrote: > Unfortunately I found recording not working in a small test [1]. > > A git bisect led to a helper function introduced by upstream in [2]. > This helper uses a function parameter of type off_t. > But the pwrite64 from glibc uses off64_t. > Therefore offset values with the highest bit set get incorrectly > converted to the 64 bit type, e.g.: 0xbffff622 -> 0xffffffffbffff622 > Therefore the write fails and rr stops. > > Attached patch makes rr work on i386 and passing most tests > in my test VM, except [3]. Have not tested for side effects at amd64. > > I am going to try to forward this to upstream too, > will update this bug then.
Ah, I assumed it would work, and I didn’t even test, let alone run the test suite. Thanks for the patch, I’ll see if the failing tests mean anything to me... Regards, Stephen
pgpVignf4umZV.pgp
Description: OpenPGP digital signature
