Hi,

Am 28.04.2020 um 00:08 schrieb Bernhard Übelacker:
> Dear Maintainer,
> I could reproduce the issue on i386 and tried to collect
> some more information.
>
> It crashes with the backtrace below.
>
> The crash seems to be caused by using the wrong data type
> in the calls to variadic functions goo_canvas_ellipse_new
> and goo_canvas_polyline_new.
>
> The modifications below made it work at i386 too.
> (Just changing integer to floating point values).
> Tested it just shortly.
>
>
>
> (gdb) bt
> #0  __strchr_sse2_bsf () at 
> ../sysdeps/i386/i686/multiarch/strchr-sse2-bsf.S:60
> #1  0xb73243ce in g_param_spec_pool_lookup (pool=0x136e260, param_name=0x1 
> <error: Cannot access memory at address 0x1>, owner_type=26014064, 
> walk_ancestors=1) at ../../../gobject/gparam.c:1071
> #2  0xb731fbce in g_object_set_valist (object=<optimized out>, 
> first_property_name=<optimized out>, var_args=0xbfb6a0b4 "") at 
> ../../../gobject/gobject.c:2289
> #3  0xb7f6e4be in goo_canvas_ellipse_new (parent=0x1685848, center_x=0, 
> center_y=0, radius_x=0, radius_y=0) at goocanvasellipse.c:214
> #4  0x0044feea in check_new_node (canvas=0x1650380, node=0x14b1600) at 
> diagram.c:935
> #5  diagram_update_nodes (canvas=0x1650380) at diagram.c:541
> #6  update_diagram (canvas=0x1650380) at diagram.c:735
> #7  0x00450828 in update_diagram_callback (data=0x0) at diagram.c:1910
> #8  0xb7076a51 in g_timeout_dispatch (source=0x14793c0, callback=0x450810 
> <update_diagram_callback>, user_data=0x0) at ../../../glib/gmain.c:4667
> #9  0xb7075e65 in g_main_dispatch (context=0x13b1fd0) at 
> ../../../glib/gmain.c:3182
> #10 g_main_context_dispatch (context=0x13b1fd0) at ../../../glib/gmain.c:3847
> #11 0xb7076269 in g_main_context_iterate (context=0x13b1fd0, 
> block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at 
> ../../../glib/gmain.c:3920
> #12 0xb7076609 in g_main_loop_run (loop=0x1478ea0) at 
> ../../../glib/gmain.c:4116
> #13 0xb799139e in gtk_main () at ../../../../gtk/gtkmain.c:1323
> #14 0x0044049e in main (argc=<optimized out>, argv=<optimized out>) at 
> main.c:316
>
>
>
>
>
> --- etherape-0.9.18.orig/src/diagram.c
> +++ etherape-0.9.18/src/diagram.c
> @@ -939,7 +939,7 @@ static gint check_new_node(node_t * node
>                                                  0.0,
>                                                  "fill-color", "white",
>                                                  "stroke-color", "black",
> -                                                "line-width", 0,
> +                                                "line-width", 0.0,
>                                   "visibility", GOO_CANVAS_ITEM_INVISIBLE,
>                                   NULL);
>        addref_canvas_obj(G_OBJECT(new_canvas_node->node_item));
> @@ -1480,16 +1480,16 @@ static gint check_new_link(link_id_t * l
>        /* set the lines position using groups positions */
>        new_canvas_link->src_item =
>              goo_canvas_polyline_new(rootgroup, TRUE, 2,
> -                                    0,0,
> -                                    1,1,
> +                                    0.0,0.0,
> +                                    1.0,1.0,
>                                      "fill-color", "tan",
>                                      NULL);
>        g_object_ref(G_OBJECT (new_canvas_link->src_item));
>  
>        new_canvas_link->dst_item =
>              goo_canvas_polyline_new(rootgroup, TRUE, 2,
> -                                    0,0,
> -                                    1,1,
> +                                    0.0,0.0,
> +                                    1.0,1.0,
>                                      "fill-color", "tan",
>                                      NULL);
>        g_object_ref(G_OBJECT (new_canvas_link->dst_item));
>
>
>
>
>
>
>
> PS.: Could not install etherape on a multiarch amd64/i386 system because
>      it tells it depends on non-existing etherape-data:i386.

Thanks for your patch. I have tested it on my amd64 machine, where I
didn't had problems. Anyway it also builds fine with your patch and I
have uploaded it.

@rghetta:
Do you want to merge it?

-- 
/*
Mit freundlichem Gruß / With kind regards,
 Patrick Matthäi
 GNU/Linux Debian Developer

  Blog: https://www.linux-dev.org/
E-Mail: pmatth...@debian.org
        patr...@linux-dev.org
*/

Reply via email to