Package: ferret-vis
Severity: normal

Dear Maintainer,

the script /usr/share/ferret-vis/bin/ferret_paths sets the FER_GO variable as if it were a standard search path with paths separated by colons.

As far as I can tell, ferret_c expects paths to be separated by spaces instead.

In a completely fresh Buster installation:

    apt install ferret-vis
    . /usr/share/ferret-vis/bin/ferret_paths
    ferret_c
    GO tutorial

Produces:
 **TMAP ERR: non-existent or not on line

/usr/share/ferret-vis/jnls/go:/usr/share/ferret-vis/jnls/contrib:/usr/share/ferret-vis/jnls/examples/tutorial

Additionally, trying to list files via Fgo will fail.

However, if we do this:
    export FER_GO="$(echo $FER_GO | sed 's/:/ /g')"

and repeat:
    ferret_c
    GO tutorial

The tutorial will run.

If we change ferret_paths to export FER_GO like this:

export FER_GO="${FER_GO-${FER_DIR}/jnls/go ${FER_DIR}/jnls/contrib ${FER_DIR}/jnls/examples}"

Fgo will find the tutorial and ferret_c will run it with a single 'GO tutorial'.

I think that single line change is enough. I did a quick fix locally (see patch) and can confirm it works.


kind regards
Malte zu Klampen
From 15efcd5ba8224afaf6e4acf6f106904054a09ecf Mon Sep 17 00:00:00 2001
From: Malte zu Klampen <malte.zuklam...@ifg.uni-kiel.de>
Date: Thu, 14 May 2020 12:23:15 +0200
Subject: [PATCH] FER_GO expects spaces, not colons

---
 debian/patches/ferret_paths.patch | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/patches/ferret_paths.patch 
b/debian/patches/ferret_paths.patch
index dbc5d58..236c2bd 100644
--- a/debian/patches/ferret_paths.patch
+++ b/debian/patches/ferret_paths.patch
@@ -17,7 +17,7 @@ Index: ferret-vis-6.6.2/environment/bin/ferret_paths
 +export 
FER_EXTERNAL_FUNCTIONS=${FER_EXTERNAL_FUNCTIONS-/usr/lib/ferret-vis/external_functions}
 +export FER_DSETS=${FER_DSETS-${FER_DIR}/datasets}
 +export FER_WEB_BROWSER=${FER_WEB_BROWSER-www-browser}
-+export 
FER_GO=${FER_GO-${FER_DIR}/jnls/go:${FER_DIR}/jnls/contrib:${FER_DIR}/jnls/examples}
++export FER_GO="${FER_GO-${FER_DIR}/jnls/go ${FER_DIR}/jnls/contrib 
${FER_DIR}/jnls/examples}"
 +export FER_DATA=${FER_DATA-${FER_DIR}/data}
 +export FER_DESCR=${FER_DESCR-${FER_DIR}/descr}
 +export FER_GRIDS=${FER_GRIDS-${FER_DIR}/grids}
-- 
2.20.1

Reply via email to