Package: munin-plugins-core
Version: 2.0.49-1
Severity: normal

Dear Maintainer,

Recent changes to bullseye and buster-backports systemd packages that
split systemd-timesyncd to depend on alternatives like ntpsec (among
others, but not classic ntpd) nudged me to upgrade from classic ntpd to
ntpsec on a couple servers.  These servers have munin-node monitoring
their ntp daemons.  After the move from classic ntpd to ntpsec caused
the following plugins to begin failing:

  * ntp_kernel_err
  * ntp_kernel_pll_freq
  * ntp_kernel_pll_off

Each of these are shell scripts that perform a version check on the ntpq
binary, then fallback on ntpdc binary if the version isn't new enough.
However with the ntpsec package, two problems arise:

  * ntpsec's ntpq command returns a version string that's "younger" than
    NTP classic's.

      + ntpsec: ntpsec-1.1.3 2019-11-18T06:04:00Z
      + ntpd: ntpq 4.2.8p12@1.3728-o (1)

  * ntpsec doesn't include the ntpdc binary and fallback fails.

      + /etc/munin/plugins/ntp_kernel_err: ntpdc: not found

The line of shell script in question is:

  if [ "$(ntpq -c version | grep --extended-regexp --only-matching 
'[[:digit:]]\.[[:digit:]]\.[[:digit:]]' | tr -d '.')" -ge 427 ]
  then
    ntpq -c kerninfo | awk '/^estimated error:/ { print $3 / 1000 }'
  else
    ntpdc -c kerninfo | awk '/^estimated error:/ { print $3 }'
  fi

I believe changing these to support ntpsec will be trivial.  Patch to
follow ;-)

-- System Information:
Debian Release: 10.3
  APT prefers stable
  APT policy: (701, 'stable'), (500, 'stable-updates')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-8-cloud-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages munin-plugins-core depends on:
ii  munin-common  2.0.49-1
ii  perl          5.28.1-6

Versions of packages munin-plugins-core recommends:
ii  libnet-snmp-perl  6.0.1-5

Versions of packages munin-plugins-core suggests:
pn  acpi | lm-sensors                 <none>
pn  conntrack                         <none>
pn  default-mysql-client              <none>
pn  ethtool                           <none>
pn  hdparm                            <none>
ii  libcache-cache-perl               1.08-2
pn  libdbd-mysql-perl                 <none>
pn  libdbd-pg-perl                    <none>
ii  libhttp-date-perl                 6.02-1
pn  liblwp-useragent-determined-perl  <none>
ii  libnet-dns-perl                   1.19-1
ii  libnet-ip-perl                    1.26-2
pn  libnet-irc-perl                   <none>
ii  libnet-ldap-perl                  1:0.6500+dfsg-1
pn  libnet-netmask-perl               <none>
pn  libnet-telnet-perl                <none>
ii  libxml-parser-perl                2.44-4
ii  libxml-simple-perl                2.25-1
ii  logtail                           1.3.20
ii  net-tools                         1.60+git20180626.aebd88e-1
ii  python3                           3.7.3-1
pn  ruby                              <none>
pn  smartmontools                     <none>

-- no debconf information

-- 
Gerald Turner <gtur...@unzane.com>        Encrypted mail preferred!
OpenPGP: 4096R / CA89 B27A 30FA 66C5 1B80  3858 EC94 2276 FDB8 716D

Attachment: signature.asc
Description: PGP signature

Reply via email to