tag 950964 +patch thanks On Sun, May 3, 2020 at 4:56 PM Julian Gilbey <jul...@d-and-j.net> wrote: > I'm slowly working on packaging the newer versions, but it is proving > to be quite difficult.
Hi Julian, Totally understand; I know anki had some major architectural changes recently that I'm sure are making your life all sorts of fun. I've backported the patch from upstream to fix the issue in the older version, so if you want to fix this issue separately from the upstream version bump, you should be able to do that easily. I've tested and confirmed this patch fixes the problem, and applies cleanly to the version of anki you have in master in salsa right now. Sincerely, -- Harlan Lieberman-Berg ~hlieberman
Description: Fix mpv arguments to prevent failures In mpv 0.31.0, it started interpreting its arguments strictly, such that you must pass the option value after an equals sign. As a result of this, anki started incorrectly calling mpv and crashing with a warning about the version of mpv being too old. This patch, backported from a newer version of anki, corrects this problem. Author: Harlan Lieberman-Berg <hlieber...@debian.org> Origin: https://github.com/ankitects/anki/commit/ccd715013609133c55e83924734efa78abc03326 Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=950964 Index: anki/anki/mpv.py =================================================================== --- anki.orig/anki/mpv.py +++ anki/anki/mpv.py @@ -104,9 +104,9 @@ class MPVBase: """ self.argv = [self.executable] self.argv += self.default_argv - self.argv += ["--input-ipc-server", self._sock_filename] + self.argv += ["--input-ipc-server=" + self._sock_filename] if self.window_id is not None: - self.argv += ["--wid", str(self.window_id)] + self.argv += ["--wid=" + str(self.window_id)] def _start_process(self): """Start the mpv process. @@ -568,4 +568,3 @@ class MPV(MPVBase): """Set the value of property `name`. """ return self.command("set_property", name, value) -
