Subject: davmail: minor backporting issues
Package: davmail
Version: 5.5.1.3299-2
Severity: wishlist
Tags: patch

I was trying to build this on buster and hit a couple of small issues.
Not sure how many of these qualify as 'bugs' vs 'features' but thought
I would report just in case some need addressing.

First, the dependency 'debhelper-compat (=12)' seems to lead to an
error

 % dpkg-buildpackage -us -uc
 dpkg-buildpackage: info: source package davmail
 dpkg-buildpackage: info: source version 5.5.1.3299-2
 dpkg-buildpackage: info: source distribution UNRELEASED
 dpkg-buildpackage: info: source changed by Debian Janitor <jani...@jelmer.uk>
 dpkg-buildpackage: info: host architecture amd64
  dpkg-source --before-build .
 dpkg-source: info: using patch list from debian/patches/series
 dpkg-source: info: applying 0001-no-windows-service.patch
 dpkg-source: info: applying 0006-Disable-the-check-for-a-new-release.patch
  fakeroot debian/rules clean
 dh clean --with javahelper
    debian/rules override_dh_auto_clean
 make[1]: Entering directory '/var/tmp/git/clones/davmail'
 test -d lib || mkdir lib
 dh_auto_clean
         ant -propertyfile ./debian/ant.properties clean
 Buildfile: /var/tmp/git/clones/davmail/build.xml

 clean:

 BUILD SUCCESSFUL
 Total time: 0 seconds
 make[1]: Leaving directory '/var/tmp/git/clones/davmail'
    jh_clean
 dpkg-query: package 'debhelper-compat' is not installed
 Use dpkg --contents (= dpkg-deb --contents) to list archive files contents.
 jh_linkjars: dpkg -L "debhelper-compat" returned exit code 1
    dh_clean
  dpkg-source -b .
 dpkg-source: info: using source format '3.0 (quilt)'
 dpkg-source: info: building davmail using existing 
./davmail_5.5.1.3299.orig.tar.gz
 dpkg-source: info: using patch list from debian/patches/series
 dpkg-source: warning: ignoring deletion of directory src/data
 dpkg-source: info: building davmail in davmail_5.5.1.3299-2.debian.tar.xz
 dpkg-source: info: building davmail in davmail_5.5.1.3299-2.dsc
  debian/rules build
 dh build --with javahelper
    dh_update_autotools_config
    dh_autoreconf
    dh_auto_configure
    jh_linkjars
 dpkg-query: package 'debhelper-compat' is not installed
 Use dpkg --contents (= dpkg-deb --contents) to list archive files contents.
 jh_linkjars: dpkg -L "debhelper-compat" returned exit code 1
 make: *** [debian/rules:5: build] Error 1
 dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2


I worked around this like so

diff --git a/debian/control b/debian/control
index e0972dde..efe2adc0 100644
--- a/debian/control
+++ b/debian/control
@@ -3,7 +3,7 @@ Maintainer: Alexandre Rossi <alexandre.ro...@gmail.com>
Uploaders: Geert Stappers <stapp...@debian.org>
Section: net
Priority: optional
-Build-Depends: debhelper-compat (=12),
+Build-Depends: debhelper (>= 12),
               default-jdk,
               ant,
               ant-optional,

as well as reinstating the debian/compat file

 echo 12 >debian/compat

After a bit of digging it seems this was fixed in javahelper-0.72.10
(see #933715). So probably nothing needs to be done here.


When it came to installation, I got this error

 adduser: Please enter a username matching the regular expression configured
 via the NAME_REGEX configuration variable.  Use the `--force-badname'
 option to relax this check or reconfigure NAME_REGEX.
 dpkg: error processing package davmail (--install):

Which this patch fixes

index e3185b58..7bcaad57 100644
--- a/debian/postinst
+++ b/debian/postinst
@@ -6,7 +6,7 @@ if ! pidof systemd > /dev/null; then
    USER=_davmail

    if ! getent passwd $USER > /dev/null; then
-        adduser --quiet --system --no-create-home --home /var/lib/$USER $USER
+        adduser --quiet --system --no-create-home --force-all --home 
/var/lib/$USER $USER
    fi

    for i in /var/log/davmail /var/lib/$USER;


Note that --force-badname is deprecated, according to dpkg-statoverride;
I get this warning if I use -force-badname

 : warning: deprecated --force option; use --force-all instead

I briefly poked around in the adduser git but I don't see where this warning
is coming from.

Kind regards
Vince


-- System Information:
Debian Release: 10.3
 APT prefers stable
 APT policy: (990, 'stable'), (500, 'stable-debug')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-8-amd64 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_AU:en (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages davmail depends on:
ii  adduser                                           3.118
ii  default-jre-headless [java9-runtime-headless]     2:1.11-71
ii  init-system-helpers                               1.56+nmu1
ii  jarwrapper                                        0.72.9
ii  libcommons-codec-java                             1.11-1
ii  libcommons-httpclient-java                        3.1-15
ii  libcommons-logging-java                           1.2-2
ii  libhtmlcleaner-java                               2.21-5
ii  libhttpclient-java                                4.5.7-1
ii  libjackrabbit-java                                2.18.0+r2.14.6-1
ii  libjcifs-java                                     1.3.19-2
ii  libjettison-java                                  1.4.0-1
ii  liblog4j1.2-java                                  1.2.17-8
ii  libmail-java                                      1.6.2-1
ii  libservlet-api-java                               4.0.1-2
ii  libslf4j-java                                     1.7.25-3
ii  libstax2-api-java                                 4.1-1
ii  libwoodstox-java                                  1:5.1.0-2
ii  logrotate                                         3.14.0-4
ii  lsb-base                                          10.2019051400
ii  openjdk-11-jre-headless [java9-runtime-headless]  11.0.7+10-3~deb10u1

davmail recommends no packages.

Versions of packages davmail suggests:
ii  libopenjfx-java         11.0.2+1-1
pn  libswt-cairo-gtk-4-jni  <none>
pn  libswt-gtk2-4-jni       <none>

-- Configuration Files:
/etc/davmail.properties changed [not included]

-- no debconf information

Reply via email to