tags 928814 + patch thanks On Sat, 11 Jan 2020 11:30:36 -0600 jtl <jt...@yahoo.com> wrote: > *Distribution vendors* (i.e. Debian) may override this or any other > default setting by installing a vendor override file alongside the > schema file. > > In short Debian never bothered to configure > package-update-indicator !!!
I think that's a bit blunt/rude but basically correct. Please find attached a patch which should set the example default which seemed sensible to me. This is my first patch in a while and first time with some of the new tools so please excuse any errors. I've not strengthened the Recommends gnome-packagekit to Depends because if gpk-update-viewer is missing the menu item will do nothing, but it did nothing before anyway! Hope that helps, -- MJR http://mjr.towers.org.uk/ Member of http://www.debian.org/ (but this email is my personal view only)
>From e2319e4dd2cc94742e1a0a75e2d612af13e74d68 Mon Sep 17 00:00:00 2001 From: MJ Ray <m...@phonecoop.coop> Date: Fri, 17 Apr 2020 12:17:10 +0100 Subject: [PATCH] * debian/patches/10_vendor_update_command.patch: add a reasonable default (Closes: #928814) * debian/tests/control: add test for update-command default being set in schema --- debian/patches/10_vendor_update_command.patch | 20 +++++++++++++++++++ debian/tests/control | 2 ++ 2 files changed, 22 insertions(+) create mode 100644 debian/patches/10_vendor_update_command.patch create mode 100644 debian/tests/control diff --git a/debian/patches/10_vendor_update_command.patch b/debian/patches/10_vendor_update_command.patch new file mode 100644 index 0000000..1ad0d8d --- /dev/null +++ b/debian/patches/10_vendor_update_command.patch @@ -0,0 +1,20 @@ +diff --git a/10_vendor_update_command.gschema.override b/10_vendor_update_command.gschema.override +new file mode 100644 +index 0000000..00e3919 +--- /dev/null ++++ b/10_vendor_update_command.gschema.override +@@ -0,0 +1,2 @@ ++[org.guido-berhoerster.code.package-update-indicator] ++update-command='/usr/bin/gpk-update-viewer' +diff --git a/Makefile b/Makefile +index a83d779..105cf57 100644 +--- a/Makefile ++++ b/Makefile +@@ -269,7 +269,5 @@ dist: clobber + -s ',^\.$$,,' -s ',\./,$(DISTNAME)/,' . | \ + $(GZIP) > $(DISTNAME).tar.gz + +--include local.mk +- + -include $(patsubst %.o,%.d,$(OBJS)) + -include $(patsubst %.gresource.xml,%.gresource.d,$(GRESOURCE_FILES)) diff --git a/debian/tests/control b/debian/tests/control new file mode 100644 index 0000000..77282f5 --- /dev/null +++ b/debian/tests/control @@ -0,0 +1,2 @@ +# Tests: update-command-defaults-to-gpk-update-viewer +Test-command: gsettings get org.guido-berhoerster.code.package-update-indicator update-command | grep "^'/usr/bin/gpk-update-viewer'$" -- 2.20.1
